Page MenuHomePhabricator
Differential D7604

[lib] Make threadInfo.roles read-only
ClosedPublic
Actions

Authored by ashoat on Apr 25 2023, 4:06 AM.
Tags
None
Referenced Files
F2208663: D7604.id.diff
Sun, Jul 7, 2:38 PM
Unknown Object (File)
Fri, Jul 5, 1:35 PM
Unknown Object (File)
Tue, Jul 2, 12:06 PM
Unknown Object (File)
Sat, Jun 29, 12:24 AM
Unknown Object (File)
Tue, Jun 18, 1:28 AM
Unknown Object (File)
Sun, Jun 16, 3:58 PM
Unknown Object (File)
Wed, Jun 12, 6:22 AM
Unknown Object (File)
May 26 2024, 1:58 PM
View All 46 Files
Subscribers
None

Details

Reviewers
atul
tomek
Commits
rCOMM02d10a36bf01: [lib] Make threadInfo.roles read-only
Summary

Noticed this in D7601.

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.Apr 25 2023, 4:06 AM
Harbormaster completed remote builds in B18731: Diff 25653.Apr 25 2023, 4:23 AM
ashoat requested review of this revision.Apr 25 2023, 4:23 AM
atul accepted this revision.Apr 25 2023, 10:42 AM

Thanks for catching this

This revision is now accepted and ready to land.Apr 25 2023, 10:42 AM
Closed by commit rCOMM02d10a36bf01: [lib] Make threadInfo.roles read-only (authored by ashoat). · Explain WhyApr 25 2023, 12:36 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM02d10a36bf01: [lib] Make threadInfo.roles read-only.

Revision Contents
Changeset List

PathSize
lib/
types/
8 lines

Diff 25699

View Options

lib/types/thread-types.js

Loading...