[web] move checking for desktop Safari to constant
ClosedPublic
Actions

Authored by kamil on Jun 15 2023, 4:33 AM.

Details

Reviewers

tomek

Commits

rCOMMf65a4f679994: [web] move checking for desktop Safari to constant

Summary

I misunderstood @tomek's suggestion from here: https://phab.comm.dev/D8124?id=27491#inline-52847

Moving not only function result to const but entire logic as this will not change during app lifetime (this is not true for tests but this is handled separately)

Test Plan

Check if this const is truthy for Safari
Check if this const is falsy for other browser (like chrome)

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Jun 15 2023, 4:33 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJun 15 2023, 4:33 AM

kamil published this revision for review.Jun 15 2023, 4:41 AM

kamil added inline comments.

web/database/utils/db-utils.js
50 ↗	(On Diff #27805)	`browser &&` is needed because of tests, in `jest` function `detectBrowser()` returns `null`, and we need this value to initialize `isDesktopSafari` const even if this does not influence tests at all