Page MenuHomePhabricator
Differential D3829

[services] Tunnelbroker - decompose cmake
ClosedPublic
Actions

Authored by • karol on Apr 25 2022, 1:30 AM.
Tags
None
Referenced Files
F3541222: D3829.diff
Thu, Dec 26, 6:07 AM
Unknown Object (File)
Thu, Dec 19, 7:08 PM
Unknown Object (File)
Thu, Dec 19, 7:08 PM
Unknown Object (File)
Thu, Dec 19, 7:08 PM
Unknown Object (File)
Thu, Dec 19, 7:03 PM
Unknown Object (File)
Fri, Dec 13, 5:41 PM
Unknown Object (File)
Thu, Dec 5, 7:13 PM
Unknown Object (File)
Nov 10 2024, 12:39 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
tomek

Details

Reviewers
tomek
• max
• jim
ashoat
Commits
rCOMM4897c3d771a3: [services] Tunnelbroker - decompose cmake
Summary

https://linear.app/comm/issue/ENG-496/decompose-cmake

Decomposing cmake for the Tunnelbroker service. I extracted folly and gRPC parts from it, couldn't see too much boilerplate for other libs, plus the two I mentioned are mutual for all services.

Test Plan

It should just build

cd services
yarn run-tunnelbroker-service

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• karol created this revision.Apr 25 2022, 1:30 AM
Herald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptApr 25 2022, 1:30 AM
• karol edited the summary of this revision. (Show Details)Apr 25 2022, 1:32 AM
• karol edited the test plan for this revision. (Show Details)
• karol added reviewers: tomek, • max.
Harbormaster completed remote builds in B8492: Diff 11838.Apr 25 2022, 1:35 AM
• karol requested review of this revision.Apr 25 2022, 1:35 AM
• max accepted this revision.Apr 25 2022, 1:59 AM

Thanks, @karol-bisztyga for doing this!
I was thinking about optimization of CmakeLists too because it's too monstrous now.

This revision is now accepted and ready to land.Apr 25 2022, 1:59 AM
• karol added 1 blocking reviewer(s): tomek.Apr 25 2022, 6:52 AM

Cool, thanks for the review! Adding Tomek as blocking.

This revision now requires review to proceed.Apr 25 2022, 6:52 AM
ashoat accepted this revision.Apr 25 2022, 10:06 AM
ashoat added a reviewer: • jim.

Thanks for making this improvement! Seems like this is just moving some specific into some new files, so it seems safe

tomek accepted this revision.Apr 26 2022, 4:23 AM
This revision is now accepted and ready to land.Apr 26 2022, 4:23 AM
Closed by commit rCOMM4897c3d771a3: [services] Tunnelbroker - decompose cmake (authored by • karol). · Explain WhyApr 26 2022, 4:36 AM
This revision was automatically updated to reflect the committed changes.
• karol added a commit: rCOMM4897c3d771a3: [services] Tunnelbroker - decompose cmake.

Revision Contents
Changeset List

PathSize
services/
tunnelbroker/
69 lines
cmake-components/
54 lines
22 lines

Diff 11838

View Options

services/tunnelbroker/CMakeLists.txt

Loading...
View Options

services/tunnelbroker/cmake-components/folly.cmake

Loading...
View Options

services/tunnelbroker/cmake-components/grpc.cmake

Loading...