Page MenuHomePhabricator
Differential D4003

[services] Document base reactor
ClosedPublic
Actions

Authored by • karol on May 11 2022, 7:37 AM.
Tags
None
Referenced Files
F3279525: D4003.id12544.diff
Sat, Nov 16, 8:46 AM
F3277641: D4003.id12634.diff
Sat, Nov 16, 7:57 AM
F3276668: D4003.id12644.diff
Sat, Nov 16, 7:33 AM
F3272954: D4003.diff
Sat, Nov 16, 5:47 AM
Unknown Object (File)
Sun, Nov 3, 9:33 PM
Unknown Object (File)
Sun, Nov 3, 9:33 PM
Unknown Object (File)
Sun, Nov 3, 9:33 PM
Unknown Object (File)
Sun, Nov 3, 9:33 PM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
tomek

Details

Reviewers
ashoat
tomek
Commits
rCOMM0c347d82e6df: [services] Document base reactor
Summary

Depends on D4002

https://linear.app/comm/issue/ENG-969/add-documentation-for-the-reactor-base-classes

Test Plan

None - there are just comments

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• karol created this revision.May 11 2022, 7:37 AM
Herald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptMay 11 2022, 7:37 AM
• karol edited the summary of this revision. (Show Details)May 11 2022, 7:41 AM
• karol edited the test plan for this revision. (Show Details)
• karol added reviewers: ashoat, tomek.
• karol added a parent revision: D4002: [services] Fix reactor status holder.
• karol added a child revision: D4004: [services] Add documentation for base reactors.
Harbormaster completed remote builds in B9006: Diff 12544.May 11 2022, 7:46 AM
• karol requested review of this revision.May 11 2022, 7:46 AM
ashoat accepted this revision.May 11 2022, 6:06 PM
ashoat added 1 blocking reviewer(s): tomek.
ashoat added inline comments.
services/lib/src/BaseReactor.h
28 ↗(On Diff #12544)

Typo

• karol added inline comments.May 12 2022, 2:11 AM
services/lib/src/BaseReactor.h
28 ↗(On Diff #12544)

right, thx

tomek accepted this revision.May 12 2022, 3:18 AM

Looks ok, but could you modify it a bit by starting your sentences with uppercase letters and ending with dots?

This revision is now accepted and ready to land.May 12 2022, 3:18 AM
• karol updated this revision to Diff 12634.May 13 2022, 3:21 AM

Improve style, fix typo

Harbormaster completed remote builds in B9088: Diff 12634.May 13 2022, 3:26 AM
Closed by commit rCOMM0c347d82e6df: [services] Document base reactor (authored by • karol). · Explain WhyMay 13 2022, 4:09 AM
This revision was automatically updated to reflect the committed changes.
• karol added a commit: rCOMM0c347d82e6df: [services] Document base reactor.

Revision Contents
Changeset List

PathSize
services/
lib/
src/
10 lines

Diff 12644

View Options

services/lib/src/BaseReactor.h

Loading...