Page MenuHomePhabricator

[native][lib] "Permanently" make changes for release
ClosedPublic

Authored by atul on May 24 2022, 12:14 PM.
Tags
None
Referenced Files
F3278512: D4123.diff
Sat, Nov 16, 8:21 AM
Unknown Object (File)
Sat, Nov 9, 11:40 AM
Unknown Object (File)
Sat, Nov 9, 11:40 AM
Unknown Object (File)
Sat, Nov 9, 11:40 AM
Unknown Object (File)
Sat, Nov 9, 11:40 AM
Unknown Object (File)
Sat, Nov 9, 11:40 AM
Unknown Object (File)
Fri, Nov 8, 8:07 AM
Unknown Object (File)
Tue, Nov 5, 2:00 AM

Details

Summary

We made changes to file-utils:mediaConfig and media-gallery-keyboard:fetchPhotos to accommodate video message work while it was in progress. The change in file-utils was for treating animated GIFs as videos... and the change in media-gallery-keyboard was for including videos in the media selection gallery.

Since the ability to send video messages still isn't ready, the changes have to be reverted before every release... and "un-reverted" after each release. This gets pretty tedious and adds some overhead to the release process (two extra commits).

Since video messages aren't actively being worked on, we decided in ENG-170 (https://linear.app/comm/issue/ENG-170/daily-iosandroid-releases) that it was reasonable to make the changes "permanently."

I left some comments in the code near the changes with steps to re-introduce them when work on video messages starts back up.

Test Plan

NA

Diff Detail

Repository
rCOMM Comm
Branch
landmay24 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul edited the summary of this revision. (Show Details)
atul requested review of this revision.May 24 2022, 12:28 PM
This revision is now accepted and ready to land.May 24 2022, 12:33 PM