Paths

Table of Contentst

-
services/tunnelbroker/src/DeliveryBroker/
-
tunnelbroker/
-
src/
-
DeliveryBroker/
2/5
DeliveryBroker.h
2/5
DeliveryBroker.cpp

[services] Tunnelbroker - Introducing `deleteQueueIfEmpty` method for DeliveryBroker
ClosedPublic
Actions

Authored by • max on May 23 2022, 5:27 AM.

Details

Reviewers

• karol
tomek

Commits

rCOMMeb8e77a14185: [services] Tunnelbroker - Introducing `deleteQueueIfEmpty` method for…

Summary

Following the comment on D3833 introducing the deleteQueueIfEmpty method. The method purpose is if clientDeviceID messages queue is empty we don't
need to store folly::MPMCQueue for it and need to free memory to fix possible 'ghost' queues.

Linear task: ENG-1146

Test Plan

Run yarn run-tunnelbroker-service, service is built and run after.

Diff Detail

Repository

rCOMM Comm

Branch

deleteQueueIfEmpty

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• max created this revision.May 23 2022, 5:27 AM

Herald added subscribers: • abosh, • karol, atul and 3 others. · View Herald TranscriptMay 23 2022, 5:27 AM

• max edited the summary of this revision. (Show Details)May 23 2022, 5:29 AM

• max added reviewers: • karol, tomek.

Harbormaster completed remote builds in B9381: Diff 12999.May 23 2022, 5:33 AM

• max requested review of this revision.May 23 2022, 5:33 AM

• max added a child revision: D3833: [services] Tunnelbroker - Put and get messages from database in grpc handler.May 23 2022, 6:20 AM

tomek accepted this revision.May 23 2022, 9:44 AM

tomek added inline comments.

services/tunnelbroker/src/DeliveryBroker/DeliveryBroker.cpp
69–76 ↗	(On Diff #12999)	The name of this method explains clearly what happens inside, so I don't think this comment is beneficial here. I would even say that it's harmful, because it describes one specific use case of this method, but the method could be used in a lot of different contexts. I think that a lot better place for this comment is where this method is used - to explain why do we need to call it.

This revision is now accepted and ready to land.May 23 2022, 9:44 AM

The comment was removed to put it in the place where the method is used.

• max marked an inline comment as done.May 25 2022, 7:08 AM

• max added inline comments.

services/tunnelbroker/src/DeliveryBroker/DeliveryBroker.cpp
69–76 ↗	(On Diff #12999)	The name of this method explains clearly what happens inside, so I don't think this comment is beneficial here. I would even say that it's harmful, because it describes one specific use case of this method, but the method could be used in a lot of different contexts. I think that a lot better place for this comment is where this method is used - to explain why do we need to call it. Not sure about this, but I've removed the comment. Let's put it into the place where it will be used.

Harbormaster completed remote builds in B9468: Diff 13119.May 25 2022, 7:14 AM

Rebase on master.

Harbormaster completed remote builds in B9547: Diff 13241.May 31 2022, 7:26 AM

Closed by commit rCOMMeb8e77a14185: [services] Tunnelbroker - Introducing `deleteQueueIfEmpty` method for… (authored by • max). · Explain WhyMay 31 2022, 7:38 AM

This revision was automatically updated to reflect the committed changes.

• max added a commit: rCOMMeb8e77a14185: [services] Tunnelbroker - Introducing `deleteQueueIfEmpty` method for….

Revision Contents
Changeset List

Path

Size

services/

tunnelbroker/

src/

DeliveryBroker/

DeliveryBroker.h

1 line

DeliveryBroker.cpp

6 lines

Diff 13119

View Options

services/tunnelbroker/src/DeliveryBroker/DeliveryBroker.h

Show First 20 Lines • Show All 42 Lines • ▼ Show 20 Lines
import {		import {
RelationshipListItemTooltipModalRouteName,		RelationshipListItemTooltipModalRouteName,
FriendListRouteName,		FriendListRouteName,
BlockListRouteName,		BlockListRouteName,
} from '../navigation/route-names.js';		} from '../navigation/route-names.js';
import { useSelector } from '../redux/redux-utils.js';		import { useSelector } from '../redux/redux-utils.js';
import { type Colors, useColors, useStyles } from '../themes/colors.js';		import { type Colors, useColors, useStyles } from '../themes/colors.js';
import type { VerticalBounds } from '../types/layout-types.js';		import type { VerticalBounds } from '../types/layout-types.js';
		import { useNavigateToUserProfileBottomSheet } from '../user-profile/user-profile-utils.js';
import Alert from '../utils/alert.js';		import Alert from '../utils/alert.js';

type BaseProps = {		type BaseProps = {
+userInfo: AccountUserInfo,		+userInfo: AccountUserInfo,
+lastListItem: boolean,		+lastListItem: boolean,
+verticalBounds: ?VerticalBounds,		+verticalBounds: ?VerticalBounds,
+relationshipListRoute: NavigationRoute<'FriendList' \| 'BlockList'>,		+relationshipListRoute: NavigationRoute<'FriendList' \| 'BlockList'>,
+navigate: RelationshipListNavigate,		+navigate: RelationshipListNavigate,
Show All 10 Lines	type Props = {
// async functions that hit server APIs		// async functions that hit server APIs
+updateRelationships: (		+updateRelationships: (
request: RelationshipRequest,		request: RelationshipRequest,
) => Promise<RelationshipErrors>,		) => Promise<RelationshipErrors>,
// withOverlayContext		// withOverlayContext
+overlayContext: ?OverlayContextType,		+overlayContext: ?OverlayContextType,
// withKeyboardState		// withKeyboardState
+keyboardState: ?KeyboardState,		+keyboardState: ?KeyboardState,
		+navigateToUserProfileBottomSheet: (userID: string) => mixed,
};		};
class RelationshipListItem extends React.PureComponent<Props> {		class RelationshipListItem extends React.PureComponent<Props> {
editButton = React.createRef<React.ElementRef<typeof View>>();		editButton = React.createRef<React.ElementRef<typeof View>>();

render() {		render() {
const {		const {
lastListItem,		lastListItem,
removeUserLoadingStatus,		removeUserLoadingStatus,
▲ Show 20 Lines • Show All 77 Lines • ▼ Show 20 Lines	) {
>		>
<Text style={this.props.styles.blueAction}>Add</Text>		<Text style={this.props.styles.blueAction}>Add</Text>
</TouchableOpacity>		</TouchableOpacity>
);		);
}		}

return (		return (
<View style={[this.props.styles.container, borderBottom]}>		<View style={[this.props.styles.container, borderBottom]}>
		<TouchableOpacity
		ginsuAuthorUnsubmitted Done Inline Actions The red background shows the `TouchableOpacity`: I think it would be a be a better user experience if we had the entire item be a touchable instead of just the avatar/username ginsu: The red background shows the `TouchableOpacity`: {F773403} I think it would be a be a better…
		atulUnsubmitted Not Done Inline Actions What surfaces should be "touchable" is probably something we should consider as part of the Design System (at some point) CC @ashoat @ted In this particular case, it feels a little weird that we're extending so far to the right, but on the left we go just until the left edge. I guess this is a new scenario, because previously we were just listing "static" avatars/usernames and left all the interaction to the right-justified icon. Unsolicited, but if it were up to me I think it'd make sense to give the avatar/username some sort of inset to make it clear that A. the element is interactive B. the bounds of the tap target Something like: or atul: What surfaces should be "touchable" is probably something we should consider as part of the…
		ashoatUnsubmitted Not Done Inline Actions I like @atul's idea. Curious for @ted's thoughts, both on Atul's idea and also on how we can include touchable surface / interaction design of touchables in the design system ashoat: I like @atul's idea. Curious for @ted's thoughts, both on Atul's idea and also on how we can…
		tedUnsubmitted Not Done Inline Actions In this particular case, it feels a little weird that we're extending so far to the right, but on the left we go just until the left edge. I think the touch point can extend more on the left, to where `Search` starts at the input field above. @atul @ashoat I think adding touch points to the design system makes perfect sense and can be included for both web and mobile components. Each design system component lives on its own page in Figma, which will also include small documents to specifically point out the interactive touch points. These documents can point out other component rules such as places to use this component, certain rules of how to use this component, etc. For the concepts you shared, I don't think that adding an inset is necessary to point out that the element is interactive. Adding an inset feels a bit cluttered to the overall list layout. If we do want to use an inset container for the avatar and username, then reducing the separator lines (smaller, more subtle) will help with over-cluttering. I took a quick look at Discord's username touchpoints in their list. In the video, I am tapping as far right as I can before the two action buttons. The entire width seems tappable except for the two buttons. Not saying we need to do exactly how Discord handles this interaction, I wanted to see how other apps were handling this. With that, I think the UI is fine how it is, but always open if more people think we should add an inset or interactive indicator. Thank you! ted: > In this particular case, it feels a little weird that we're extending so far to the right…
		ginsuAuthorUnsubmitted Done Inline Actions For the concepts you shared, I don't think that adding an inset is necessary to point out that the element is interactive. Adding an inset feels a bit cluttered to the overall list layout. If we do want to use an inset container for the avatar and username, then reducing the separator lines (smaller, more subtle) will help with over-cluttering. I agree with this point, I think especially since we have the edit (pencil) icon to the right it would feel strange if that didn't have an inset/obvious indicator that the icon is touchable but the avatar/username does. To polish this up, I can make the entire container a touchable or at the very least, also extend the touchable to be touching the left side of this container ginsu: > For the concepts you shared, I don't think that adding an inset is necessary to point out…
		onPress={this.onPressUser}
		style={this.props.styles.userInfoContainer}
		>
<UserAvatar size="small" userID={this.props.userInfo.id} />		<UserAvatar size="small" userID={this.props.userInfo.id} />
<SingleLine style={this.props.styles.username}>		<SingleLine style={this.props.styles.username}>
{this.props.userInfo.username}		{this.props.userInfo.username}
</SingleLine>		</SingleLine>
		</TouchableOpacity>
{editButton}		{editButton}
</View>		</View>
);		);
}		}

		onPressUser = () => {
		this.props.navigateToUserProfileBottomSheet(this.props.userInfo.id);
		};

onSelect = () => {		onSelect = () => {
const { id, username } = this.props.userInfo;		const { id, username } = this.props.userInfo;
this.props.onSelect({ id, username });		this.props.onSelect({ id, username });
};		};

visibleEntryIDs() {		visibleEntryIDs() {
const { relationshipListRoute } = this.props;		const { relationshipListRoute } = this.props;
const id = {		const id = {
▲ Show 20 Lines • Show All 85 Lines • ▼ Show 20 Lines	container: {
paddingHorizontal: 24,		paddingHorizontal: 24,
paddingVertical: 10,		paddingVertical: 10,
backgroundColor: 'panelForeground',		backgroundColor: 'panelForeground',
borderColor: 'panelForegroundBorder',		borderColor: 'panelForegroundBorder',
},		},
borderBottom: {		borderBottom: {
borderBottomWidth: 1,		borderBottomWidth: 1,
},		},
		userInfoContainer: {
		flex: 1,
		flexDirection: 'row',
		},
buttonContainer: {		buttonContainer: {
flexDirection: 'row',		flexDirection: 'row',
},		},
editButtonWithMargin: {		editButtonWithMargin: {
marginLeft: 15,		marginLeft: 15,
},		},
username: {		username: {
color: 'panelForegroundSecondaryLabel',		color: 'panelForegroundSecondaryLabel',
Show All 29 Lines	) {
);		);
const colors = useColors();		const colors = useColors();
const styles = useStyles(unboundStyles);		const styles = useStyles(unboundStyles);
const dispatchActionPromise = useDispatchActionPromise();		const dispatchActionPromise = useDispatchActionPromise();
const boundUpdateRelationships = useServerCall(updateRelationships);		const boundUpdateRelationships = useServerCall(updateRelationships);
const overlayContext = React.useContext(OverlayContext);		const overlayContext = React.useContext(OverlayContext);
const keyboardState = React.useContext(KeyboardContext);		const keyboardState = React.useContext(KeyboardContext);

		const navigateToUserProfileBottomSheet =
		useNavigateToUserProfileBottomSheet();

return (		return (
<RelationshipListItem		<RelationshipListItem
{...props}		{...props}
removeUserLoadingStatus={removeUserLoadingStatus}		removeUserLoadingStatus={removeUserLoadingStatus}
colors={colors}		colors={colors}
styles={styles}		styles={styles}
dispatchActionPromise={dispatchActionPromise}		dispatchActionPromise={dispatchActionPromise}
updateRelationships={boundUpdateRelationships}		updateRelationships={boundUpdateRelationships}
overlayContext={overlayContext}		overlayContext={overlayContext}
keyboardState={keyboardState}		keyboardState={keyboardState}
		navigateToUserProfileBottomSheet={navigateToUserProfileBottomSheet}
/>		/>
);		);
});		});

export default ConnectedRelationshipListItem;		export default ConnectedRelationshipListItem;