Page MenuHomePhabricator
Differential D4157

[keyserver] Better document MySQL errno
ClosedPublic
Actions

Authored by ashoat on May 31 2022, 5:37 AM.
Tags
None
Referenced Files
F3492285: D4157.id13229.diff
Wed, Dec 18, 10:56 PM
F3492018: D4157.id13221.diff
Wed, Dec 18, 9:44 PM
F3491712: D4157.diff
Wed, Dec 18, 8:01 PM
Unknown Object (File)
Tue, Dec 17, 7:58 AM
Unknown Object (File)
Tue, Dec 17, 7:58 AM
Unknown Object (File)
Tue, Dec 17, 7:57 AM
Unknown Object (File)
Tue, Dec 17, 7:55 AM
Unknown Object (File)
Wed, Dec 4, 6:34 AM
View All Files
Subscribers
• abosh
• adrian
commpeopleops

Details

Reviewers
tomek
atul
Commits
rCOMM22ba6740b514: [keyserver] Better document MySQL errno
Summary

Using variable names here makes the code self-documenting. Initial discussion here, full reference of MySQL 5.7 error codes here.

Test Plan

Honestly I haven't tested this, but I have looked at git diff very carefully and I think it's safe

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/dockerize_node
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.May 31 2022, 5:37 AM
Herald added subscribers: • abosh, • adrian. · View Herald TranscriptMay 31 2022, 5:37 AM
ashoat added a parent revision: D4155: [keyserver] Initialize MySQL databases with the latest migration version.May 31 2022, 5:37 AM
ashoat mentioned this in D4151: [keyserver] Call setupDB from DB migration if meta table is missing.
Harbormaster completed remote builds in B9535: Diff 13221.May 31 2022, 5:44 AM
ashoat requested review of this revision.May 31 2022, 5:44 AM
tomek accepted this revision.May 31 2022, 5:45 AM
This revision is now accepted and ready to land.May 31 2022, 5:45 AM
Closed by commit rCOMM22ba6740b514: [keyserver] Better document MySQL errno (authored by ashoat). · Explain WhyMay 31 2022, 5:50 AM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM22ba6740b514: [keyserver] Better document MySQL errno.
commpeopleops added a subscriber: commpeopleops.May 31 2022, 8:00 PM

Ignore this message (Ashoat is testing Phabricator email config)

commpeopleops added a comment.May 31 2022, 8:02 PM

Ignore this message (Ashoat is testing Phabricator email config)

commpeopleops added a comment.May 31 2022, 8:23 PM

Ignore this message (Ashoat is testing Phabricator email config)

commpeopleops added a comment.May 31 2022, 8:31 PM

Ignore this message (Ashoat is testing Phabricator email config)

commpeopleops added a comment.May 31 2022, 8:35 PM

Ignore this message (Ashoat is testing Phabricator email config)

commpeopleops added a comment.Jun 5 2022, 10:29 PM

Ignore this message (Ashoat is testing Phabricator email config)

commpeopleops added a comment.Jun 6 2022, 7:25 AM

Ignore this message (Ashoat is testing Phabricator email config)

commpeopleops added a comment.Jun 6 2022, 10:32 AM

Ignore this message (Ashoat is testing Phabricator email config)

ashoat added a comment.Jun 6 2022, 10:33 AM

This is Ashoat testing a Phabricator comment over email

ashoat added a comment.Jun 6 2022, 11:16 AM

This is Ashoat posting a comment on Phabricator via email

Revision Contents
Changeset List

PathSize
keyserver/
src/
creators/
4 lines
database/
4 lines
4 lines

Diff 13221

View Options

keyserver/src/creators/day-creator.js

Loading...
View Options

keyserver/src/database/database.js

Loading...
View Options

keyserver/src/database/migrations.js

Loading...