Paths

Table of Contentst

Differential D4152

[keyserver] Extract migration config to separate file
ClosedPublic
Actions

Authored by ashoat on May 30 2022, 1:59 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Dec 19, 2:56 AM

	Unknown Object (File)
	Wed, Dec 18, 10:14 PM

	Unknown Object (File)
	Tue, Dec 17, 7:55 AM

	Unknown Object (File)
	Tue, Dec 10, 12:42 PM

	Unknown Object (File)
	Fri, Nov 22, 12:53 PM

	Unknown Object (File)
	Fri, Nov 22, 12:53 PM

	Unknown Object (File)
	Fri, Nov 22, 12:53 PM

	Unknown Object (File)
	Oct 28 2024, 2:49 AM

Subscribers

Details

Reviewers

tomek
atul

Commits

rCOMM34ecda1b7f42: [keyserver] Extract migration config to separate file

Summary

In the following diff, I'm going to check the latest migration index from setup-db.js so we can start with a default migration version.

Without this diff, that change would result in a require cycle.

Depends on D4151

Test Plan

This is a simple refactor. I tested it in combination with stack (see test plan in D4151), and also used Flow

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.May 30 2022, 1:59 PM

Herald added subscribers: • abosh, atul, • adrian. · View Herald TranscriptMay 30 2022, 1:59 PM

ashoat added a child revision: D4153: [keyserver] Extract DB version functions to separate file.May 30 2022, 2:00 PM

ashoat added a reviewer: atul.May 30 2022, 2:01 PM

Harbormaster completed remote builds in B9529: Diff 13215.May 30 2022, 2:13 PM

ashoat requested review of this revision.May 30 2022, 2:13 PM

tomek accepted this revision.May 31 2022, 5:13 AM

This revision is now accepted and ready to land.May 31 2022, 5:13 AM

Makes sense, moving the "contents" of the migrations to a separate file helps reduce clutter in migrations.js.

At some point it'll probably make sense to have a migrations directory instead of having them all in migration-config.js, but it's probably fine for now.

Closed by commit rCOMM34ecda1b7f42: [keyserver] Extract migration config to separate file (authored by ashoat). · Explain WhyMay 31 2022, 5:50 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM34ecda1b7f42: [keyserver] Extract migration config to separate file.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

database/

migration-config.js

85 lines

82 lines

Diff 13225

keyserver/src/database/migration-config.js

Loading...

keyserver/src/database/migrations.js

Loading...