[keyserver] Initialize MySQL databases with the latest migration version
ClosedPublic
Actions

Authored by ashoat on May 30 2022, 2:05 PM.

Details

Reviewers

tomek
atul

Commits

rCOMM129b2794c84a: [keyserver] Initialize MySQL databases with the latest migration version

Summary

Right now, new databases initialized with setupDB will start with no db_version in the metadata table, which corresponds to a value of -1.

This forces the migrate() code to run every single migration for the new database.

Instead, I think we should assume that setupDB is updated for any schema changes. That requires us to land changes to setupDB at the same time as introducing migrations. We should keep this requirement in mind, but I think we have stuck with it in the past.

Depends on D4154

Test Plan

Create a keyserver/.env file, eg.:

COMM_MYSQL_DATABASE=commdev
COMM_MYSQL_USER=commdev
COMM_MYSQL_PASSWORD=pass

And then run the Docker image: cd keyserver && docker-compose down -v && docker-compose up --build

Before this diff, you should see console logs indicating the migrations are being run. After this diff, no migrations are run, and the database is initialized with a version of 2 (latest migration value)

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.May 30 2022, 2:05 PM

Herald added subscribers: • abosh, • adrian. · View Herald TranscriptMay 30 2022, 2:05 PM

Harbormaster completed remote builds in B9532: Diff 13218.May 30 2022, 2:36 PM

ashoat requested review of this revision.May 30 2022, 2:36 PM

tomek accepted this revision.May 31 2022, 5:20 AM

This revision is now accepted and ready to land.May 31 2022, 5:20 AM

atul accepted this revision.May 31 2022, 5:34 AM

atul added inline comments.

keyserver/src/database/setup-db.js
21 ↗	(On Diff #13218)	The table name in the MySQL db is `metadata`... is there a reason we shouldn't mirror that and name this function `setUpMetadataTable`?

ashoat added a child revision: D4157: [keyserver] Better document MySQL errno.May 31 2022, 5:37 AM

ashoat added inline comments.May 31 2022, 5:41 AM

keyserver/src/database/setup-db.js
21 ↗	(On Diff #13218)	Good catch. I initially thought the table was named `meta`, realized that was wrong later and went back to rename things... but definitely missed this