Page MenuHomePhabricator

[web] Introduce minimally viable `Alert` component
ClosedPublic

Authored by atul on Jun 2 2022, 11:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 28, 5:29 AM
Unknown Object (File)
Fri, Dec 27, 11:49 AM
Unknown Object (File)
Fri, Dec 27, 5:43 AM
Unknown Object (File)
Thu, Dec 5, 6:48 PM
Unknown Object (File)
Nov 28 2024, 8:32 AM
Unknown Object (File)
Nov 2 2024, 2:52 PM
Unknown Object (File)
Nov 2 2024, 2:52 PM
Unknown Object (File)
Nov 2 2024, 2:52 PM

Details

Summary

At this point pretty much copied from InvalidUploadModal with title and children passed in as props. In the next diff will "consume" the Alert component in InvalidUploadModal


Depends on D4206

Test Plan

Will be tested implicitly by the next diff in the stack when we "consume" the newly introduced Alert component from InvalidUploadModal

Diff Detail

Repository
rCOMM Comm
Branch
landjune4 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul requested review of this revision.Jun 2 2022, 11:15 PM
tomek added inline comments.
web/modals/alert.react.js
16 ↗(On Diff #13323)
This revision is now accepted and ready to land.Jun 3 2022, 4:41 AM
web/modals/alert.react.js
12 ↗(On Diff #13323)

Maybe we can use something more general?

cherrypick before landing

atul marked 2 inline comments as done.Jun 4 2022, 6:15 PM
atul added inline comments.
web/modals/alert.react.js
12 ↗(On Diff #13323)

I think it makes sense for this type of Alert component to limit it to text?

I fear that opening it up to React.Node could lead to all sorts of layout/styling possibilities if people can pass anything in

atul marked an inline comment as done.

address feedback