Page MenuHomePhabricator
Differential D4262

[keyserver] Type BackupConfig
ClosedPublic
Actions

Authored by ashoat on Jun 14 2022, 10:26 AM.
Tags
None
Referenced Files
F3366318: D4262.id13496.diff
Mon, Nov 25, 10:50 AM
Unknown Object (File)
Fri, Nov 22, 12:39 PM
Unknown Object (File)
Fri, Nov 22, 12:39 PM
Unknown Object (File)
Fri, Nov 22, 12:39 PM
Unknown Object (File)
Fri, Nov 22, 12:38 PM
Unknown Object (File)
Fri, Nov 8, 4:33 PM
Unknown Object (File)
Fri, Nov 8, 8:06 AM
Unknown Object (File)
Fri, Nov 8, 7:59 AM
View All 93 Files
Subscribers
• adrian
tomek

Details

Reviewers
atul
• abosh
Commits
rCOMMccb9976f761c: [keyserver] Type BackupConfig
Summary

We should really have a type for this

Test Plan

Just Flow for this one

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Jun 14 2022, 10:26 AM
Herald added subscribers: • adrian, tomek. · View Herald TranscriptJun 14 2022, 10:26 AM
ashoat added a child revision: D4263: [keyserver] Extract getBackupInfos.Jun 14 2022, 10:28 AM
Harbormaster completed remote builds in B9748: Diff 13496.Jun 14 2022, 10:32 AM
ashoat requested review of this revision.Jun 14 2022, 10:32 AM
• abosh accepted this revision.Jun 14 2022, 11:23 AM
This revision is now accepted and ready to land.Jun 14 2022, 11:23 AM
atul accepted this revision.Jun 14 2022, 11:28 AM
atul added inline comments.
keyserver/src/cron/backups.js
19–22

I've never personally seen a facts/backups.json... but I'm guessing it looks like this

Closed by commit rCOMMccb9976f761c: [keyserver] Type BackupConfig (authored by ashoat). · Explain WhyJun 15 2022, 10:01 AM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMccb9976f761c: [keyserver] Type BackupConfig.

Revision Contents
Changeset List

PathSize
keyserver/
src/
cron/
13 lines

Diff 13496

View Options

keyserver/src/cron/backups.js

Loading...