[keyserver] Extract deleteBackup
ClosedPublic
Actions

Authored by ashoat on Jun 15 2022, 5:40 PM.

Details

Reviewers

atul
• abosh

Commits

rCOMMcc2960919b8c: [keyserver] Extract deleteBackup

Summary

Working on ENG-1234, which will also require deleting old backups. Figured I'd extract this code.

Test Plan

Tested in combination with the next diff

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Jun 15 2022, 5:40 PM

Herald added subscribers: • adrian, tomek. · View Herald TranscriptJun 15 2022, 5:40 PM

ashoat added a child revision: D4283: [keyserver] Add maxDirSizeMiB to BackupConfig.Jun 15 2022, 5:41 PM

Harbormaster completed remote builds in B9779: Diff 13536.Jun 15 2022, 5:44 PM

ashoat requested review of this revision.Jun 15 2022, 5:44 PM

• abosh accepted this revision.Jun 15 2022, 8:39 PM

• abosh added inline comments.

keyserver/src/cron/backups.js
197 ↗	(On Diff #13536)	Couldn’t this be renamed to `sortedBackupInfos` so it’s clearer on line 201 why its first index is being accessed?

This revision is now accepted and ready to land.Jun 15 2022, 8:39 PM

Feedback

Harbormaster completed remote builds in B9781: Diff 13538.Jun 16 2022, 8:32 AM

Closed by commit rCOMMcc2960919b8c: [keyserver] Extract deleteBackup (authored by ashoat). · Explain WhyJun 16 2022, 8:55 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMcc2960919b8c: [keyserver] Extract deleteBackup.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

cron/

backups.js

18 lines

Diff 13538

View Options

keyserver/src/cron/backups.js

[keyserver] Extract deleteBackupClosedPublicActions