[services] Clean up `build_base_image.sh`
ClosedPublic
Actions

Authored by • abosh on Jun 30 2022, 12:51 PM.

Details

Reviewers

ashoat
atul

Commits

rCOMM1397f1ae0adc: [services] Clean up `build_base_image.sh`

Summary

Relevant Linear issue here. Replaced [ ] with [[ ]] and added some double quotes to prevent globbing and word splitting.

Test Plan

ShellCheck, close reading.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• abosh created this revision.Jun 30 2022, 12:51 PM

Herald added subscribers: • karol, • adrian, tomek. · View Herald TranscriptJun 30 2022, 12:51 PM

• abosh added inline comments.Jun 30 2022, 12:52 PM

services/scripts/build_base_image.sh
11 ↗	(On Diff #14045)	Double quote to prevent globbing and word splitting.

• abosh edited the summary of this revision. (Show Details)Jun 30 2022, 12:52 PM

• abosh edited the test plan for this revision. (Show Details)

• abosh added 1 blocking reviewer(s): ashoat.

Harbormaster completed remote builds in B10174: Diff 14045.Jun 30 2022, 1:03 PM

• abosh requested review of this revision.Jun 30 2022, 1:03 PM

Thanks for taking this on!!

This revision is now accepted and ready to land.Jun 30 2022, 1:40 PM

Closed by commit rCOMM1397f1ae0adc: [services] Clean up `build_base_image.sh` (authored by • abosh). · Explain WhyJun 30 2022, 1:43 PM

This revision was automatically updated to reflect the committed changes.

• abosh added a commit: rCOMM1397f1ae0adc: [services] Clean up `build_base_image.sh`.

Revision Contents
Changeset List

Path

Size

services/

scripts/

build_base_image.sh

4 lines

Diff 14051

View Options

services/scripts/build_base_image.sh

[services] Clean up `build_base_image.sh`ClosedPublicActions