This is running into some errors, and I think it has to do with the difference between sh and bash.

After viewing the logs on Buildkite for the failed Docker keyserver build, I noticed that source_nvm.sh is being interpreted by sh, not bash (view the highlighted portion):

However, the shebang in source_nvm.sh says to interpret the script using bash:

(Also see: D3784)

This usually isn't an issue, but since bash is a superset of sh there's technically some things that can be run in a bash script that won't be interpreted by sh. One of those being [[ in conditional statements. This is because sh is POSIX-compliant "and no more," and thus [ is executable while [[ is not.

Anyways, I tested the Docker keyserver build locally after changing some things and it still didn't work. It cannot recognize the [[. As soon as I change it back to [, however, the keyserver builds with no errors.

Not sure why source_nvm.sh is being interpreted by sh since the shebang is for bash.

Read more about [ vs. [[ in sh and bash:

• https://stackoverflow.com/questions/3401183/bash-syntax-error-not-found
• https://stackoverflow.com/questions/17281219/what-is-not-found-error
• https://unix.stackexchange.com/questions/156769/single-or-double-brackets-and-portability

Retry Docker keyserver build

I think I figured out what was breaking this. After inspecting the errors on the Docker keyserver builds, it seems that source-nvm.sh was still being executed by sh instead of bash, even though we had updated the keyserver Dockerfile in D4429. The issue was that there were other places in the codebase that were still sourcing source-nvm.sh in the current environment as opposed to running it in bash (as the shebang in source-nvm.sh indicates).

Ran a quick find-all search for . source-nvm.sh usages instead of ./source-nvm.sh (the former is sourcing the script to run in the current environment, the latter is executing it in bash), and found 3 instances in package.json. Changed these to ./ and now the Docker keyserver builds with no errors: