Paths

Table of Contentst

[services] Clean up `run_all_services.sh`
ClosedPublic
Actions

Authored by • abosh on Jul 5 2022, 12:00 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Sep 12, 11:42 PM

	Unknown Object (File)
	Sat, Sep 7, 9:52 PM

	Unknown Object (File)
	Sep 2 2024, 3:06 PM

	Unknown Object (File)
	Aug 31 2024, 6:54 AM

	Unknown Object (File)
	Aug 29 2024, 12:00 AM

	Unknown Object (File)
	Aug 19 2024, 4:36 PM

	Unknown Object (File)
	Aug 19 2024, 4:25 PM

	Unknown Object (File)
	Aug 8 2024, 3:21 PM

View All 73 Files

Subscribers

• adrian

• karol

Details

Reviewers

ashoat
atul
tomek

Commits

rCOMM23c50285a0c1: [services] Clean up `run_all_services.sh`

Summary

Relevant Linear issue here. Added double quotes to prevent word-splitting or globbing in run_all_services.sh.

Test Plan

ShellCheck, close reading.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• abosh created this revision.Jul 5 2022, 12:00 PM

Herald added subscribers: • karol, • adrian. · View Herald TranscriptJul 5 2022, 12:00 PM

Harbormaster completed remote builds in B10303: Diff 14203.Jul 5 2022, 12:12 PM

• abosh requested review of this revision.Jul 5 2022, 12:12 PM

• abosh added inline comments.Jul 5 2022, 12:14 PM

services/scripts/run_all_services.sh
5 ↗	(On Diff #14203)	Use $(...) notation instead of legacy backticked ...

ashoat accepted this revision.Jul 5 2022, 12:19 PM

This revision is now accepted and ready to land.Jul 5 2022, 12:19 PM

Closed by commit rCOMM23c50285a0c1: [services] Clean up `run_all_services.sh` (authored by • abosh). · Explain WhyJul 5 2022, 12:26 PM

This revision was automatically updated to reflect the committed changes.

• abosh added a commit: rCOMM23c50285a0c1: [services] Clean up `run_all_services.sh`.

Revision Contents
Changeset List

Path

Size

services/

scripts/

run_all_services.sh

4 lines

Diff 14209

View Options

services/scripts/run_all_services.sh

[services] Clean up `run_all_services.sh`ClosedPublicActions