[native] Clean up `detect_abis.sh`
ClosedPublic
Actions

Authored by • abosh on Jul 7 2022, 3:43 PM.

Details

Reviewers

ashoat
atul
• karol

Commits

rCOMM8dd41c6dc66b: [native] Clean up `detect_abis.sh`

Summary

Relevant Linear issue here. More details in inline comments.

Test Plan

ShellCheck, close reading.

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• abosh created this revision.Jul 7 2022, 3:43 PM

Herald added subscribers: • adrian, tomek. · View Herald TranscriptJul 7 2022, 3:43 PM

• abosh added inline comments.Jul 7 2022, 3:45 PM

native/android/app/bash/detect_abis.sh
10	Double quote to prevent globbing and word-splitting.
18	Double quote to prevent globbing and word-splitting.

atul published this revision for review.Jul 7 2022, 4:02 PM

atul accepted this revision.

This revision is now accepted and ready to land.Jul 7 2022, 4:02 PM

Harbormaster completed remote builds in B10378: Diff 14286.Jul 7 2022, 4:02 PM

Closed by commit rCOMM8dd41c6dc66b: [native] Clean up `detect_abis.sh`. · Explain WhyJul 7 2022, 4:06 PM

This revision was automatically updated to reflect the committed changes.

• abosh added a commit: rCOMM8dd41c6dc66b: [native] Clean up `detect_abis.sh`.

Revision Contents
Changeset List

Path

Size

native/

android/

app/

bash/

detect_abis.sh

4 lines

Diff 14286

View Options

native/android/app/bash/detect_abis.sh

[native] Clean up `detect_abis.sh`ClosedPublicActions