[services] Tunnelbroker - Change `AmqpManager.send()` method arguments to use `MessageItem` in tests
ClosedPublic
Actions

Authored by • max on Jul 13 2022, 2:49 AM.

Details

Reviewers

• karol
tomek

Commits

rCOMMbc11d879493d: [services] Tunnelbroker - Change `AmqpManager.send()` method arguments to use…

Summary

This diff introducing changes in tests for AmqpManager.send() method to use MessageItem instead of arguments list.
The function changes was introduced in D4511.

Linear task: ENG-1214

Test Plan

Run tests using yarn run-unit-tests.

Diff Detail

Repository

rCOMM Comm

Branch

use-messageItem-in-amqp-test

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• max created this revision.Jul 13 2022, 2:49 AM

• max held this revision as a draft.

Herald added subscribers: • abosh, • karol, atul and 3 others. · View Herald TranscriptJul 13 2022, 2:49 AM

• max published this revision for review.Jul 13 2022, 2:50 AM

• max added a parent revision: D4511: [services] Tunnelbroker - Change `AmqpManager.send()` method arguments to use `MessageItem`.

• max added reviewers: • karol, tomek.

• max mentioned this in D4511: [services] Tunnelbroker - Change `AmqpManager.send()` method arguments to use `MessageItem`.

• max edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B10478: Diff 14425.Jul 13 2022, 3:02 AM

tomek accepted this revision.Jul 18 2022, 7:14 AM

tomek added inline comments.

services/tunnelbroker/test/AmqpManagerTest.cpp
38–39 ↗	(On Diff #14425)	Shouldn't we use brace initialization? https://www.notion.so/commapp/C-coding-standards-8c9f22b4b16a41c3a868eb5f537db1de

This revision is now accepted and ready to land.Jul 18 2022, 7:14 AM

Rebase on the stack changes. Switching to use braces.

• max marked an inline comment as done.Jul 25 2022, 12:38 PM

• max added inline comments.

services/tunnelbroker/test/AmqpManagerTest.cpp
38–39 ↗	(On Diff #14425)	Shouldn't we use brace initialization? https://www.notion.so/commapp/C-coding-standards-8c9f22b4b16a41c3a868eb5f537db1de Yes, we can use braces here instead.