Paths

Table of Contentst

Differential D4608

[web] Introduce `Sidebar` component
ClosedPublic
Actions

Authored by • jacek on Jul 22 2022, 8:21 AM.

Tags

None

Referenced Files

	F3301290: D4608.id14816.diff
	Mon, Nov 18, 1:35 AM

	F3301034: D4608.diff
	Sun, Nov 17, 11:25 PM

	Unknown Object (File)
	Sat, Nov 9, 3:34 PM

	Unknown Object (File)
	Sat, Nov 9, 1:21 PM

	Unknown Object (File)
	Sat, Nov 9, 10:41 AM

	Unknown Object (File)
	Sat, Nov 9, 9:08 AM

	Unknown Object (File)
	Oct 7 2024, 4:07 PM

	Unknown Object (File)
	Oct 7 2024, 4:07 PM

View All 95 Files

Subscribers

Details

Reviewers

tomek
atul
ashoat

Commits

rCOMM296f64250f2e: [web] Introduce `Sidebar` component

Summary

Introduce component displaying single Sidebar item in the list in Sidebars Modal on web.

Screenshot_Google Chrome_2022-07-22_173015.png (678×474 px, 38 KB)

Test Plan

The component will be used in the following diffs introducing the modal.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• jacek created this revision.Jul 22 2022, 8:21 AM

Herald added subscribers: • abosh, • adrian, ashoat. · View Herald TranscriptJul 22 2022, 8:21 AM

• jacek edited the summary of this revision. (Show Details)Jul 22 2022, 8:30 AM

• jacek added a child revision: D4609: [web] Introduce `SidebarList` component.Jul 22 2022, 8:32 AM

• jacek added a parent revision: D4607: [web] Add SVGs with arrows for sidebars modal.

Harbormaster completed remote builds in B10775: Diff 14816.Jul 22 2022, 8:33 AM

• jacek requested review of this revision.Jul 22 2022, 8:33 AM

Adding @ashoat because this diff touches the copy (a little, but still).

web/modals/threads/sidebars/sidebars-modal.css
1–2 ↗	(On Diff #14816)	We should prefer using semantic html, ideally already defined somewhere. So it's better to use `button` with custom style. It's the best to search the codebase for already defined component that is used for this purpose (a button without a style).

The screenshot looks great to me!

This revision is now accepted and ready to land.Jul 25 2022, 6:22 AM

Replace div with button

• jacek requested review of this revision.Jul 26 2022, 4:37 AM

Harbormaster completed remote builds in B10877: Diff 14955.Jul 26 2022, 4:45 AM

tomek accepted this revision.Jul 26 2022, 6:55 AM

This revision is now accepted and ready to land.Jul 26 2022, 6:55 AM

Closed by commit rCOMM296f64250f2e: [web] Introduce `Sidebar` component (authored by • jacek). · Explain WhyJul 26 2022, 8:30 AM

This revision was automatically updated to reflect the committed changes.

• jacek added a commit: rCOMM296f64250f2e: [web] Introduce `Sidebar` component.

Revision Contents
Changeset List

Path

Size

web/

modals/

threads/

sidebars/

sidebar.react.js

79 lines

sidebars-modal.css

52 lines

1 line

Diff 14986

web/modals/threads/sidebars/sidebar.react.js

Loading...

web/modals/threads/sidebars/sidebars-modal.css

Loading...

web/theme.css

Loading...