Paths

Table of Contentst

Differential D4693

[services] Tunnelbroker - Fix `IDs` in Terraform dynamodb table attributes
ClosedPublic
Actions

Authored by • max on Aug 1 2022, 6:50 AM.

Tags

None

Referenced Files

	F3301599: D4693.id15134.diff
	Mon, Nov 18, 2:31 AM

	Unknown Object (File)
	Sat, Nov 2, 5:29 PM

	Unknown Object (File)
	Oct 18 2024, 2:07 AM

	Unknown Object (File)
	Oct 7 2024, 3:26 PM

	Unknown Object (File)
	Oct 7 2024, 3:26 PM

	Unknown Object (File)
	Oct 7 2024, 3:26 PM

	Unknown Object (File)
	Oct 7 2024, 3:24 PM

	Unknown Object (File)
	Sep 26 2024, 3:29 PM

Subscribers

Details

Reviewers

• karol
tomek

Commits

rCOMM07c8dd3b7ad3: [services] Tunnelbroker - Fix `IDs` in Terraform dynamodb table attributes

Summary

This diff is a fix.
After updating the field names to use ID instead of Id some of the fields used the old names which caused errors while running in the cloud. The codebase is already
using the ID pattern. The changes need to be made in the Terraform script.

Linear task: ENG-1492

Test Plan

Run yarn init-local-cloud and run database related unit tests in test/DatabaseManagerTest.cpp.

Diff Detail

Repository

Branch

fix-IDs-in-terraform

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• max created this revision.Aug 1 2022, 6:50 AM

• max held this revision as a draft.

Herald added subscribers: • abosh, • karol, atul and 3 others. · View Herald TranscriptAug 1 2022, 6:50 AM

• max edited the summary of this revision. (Show Details)Aug 1 2022, 6:51 AM

• max added reviewers: • karol, tomek.

• max edited the summary of this revision. (Show Details)

• max published this revision for review.Aug 1 2022, 6:59 AM

• max added a child revision: D4694: [services] Tunnelbroker - Change `findMessageItem`, `removeMessageItem` to use composite key.

Harbormaster completed remote builds in B11000: Diff 15134.Aug 1 2022, 7:00 AM

• max added a child revision: D4695: [services] Tunnelbroker - Remove `ToDeviceID` index from messages table.Aug 1 2022, 7:07 AM

• max added a child revision: D4696: [services] Tunnelbroker - Fix table names to use config-only instead of constant.Aug 1 2022, 7:17 AM

tomek accepted this revision.Aug 2 2022, 2:44 AM

This revision is now accepted and ready to land.Aug 2 2022, 2:44 AM

Closed by commit rCOMM07c8dd3b7ad3: [services] Tunnelbroker - Fix `IDs` in Terraform dynamodb table attributes (authored by • max). · Explain WhyAug 2 2022, 3:53 AM

This revision was automatically updated to reflect the committed changes.

• max added a commit: rCOMM07c8dd3b7ad3: [services] Tunnelbroker - Fix `IDs` in Terraform dynamodb table attributes.

Revision Contents
Changeset List

Path

Size

services/

terraform/

dynamodb-test.tf

12 lines

12 lines

Diff 15134

services/terraform/dynamodb-test.tf

Loading...

services/terraform/dynamodb.tf

Loading...