Page MenuHomePhabricator
Differential D4837

[native] Fix up redux-persist types
ClosedPublic
Actions

Authored by ashoat on Aug 15 2022, 1:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 18 2025, 9:13 AM
Unknown Object (File)
Feb 7 2025, 1:15 AM
Unknown Object (File)
Feb 3 2025, 2:19 PM
Unknown Object (File)
Jan 30 2025, 5:36 PM
Unknown Object (File)
Jan 30 2025, 5:36 PM
Unknown Object (File)
Jan 30 2025, 10:32 AM
Unknown Object (File)
Jan 30 2025, 9:05 AM
Unknown Object (File)
Jan 23 2025, 6:25 PM
View All 82 Files
Subscribers
• abosh
• adrian
atul

Details

Reviewers
tomek
Commits
rCOMM722474a2e0fe: [native] Fix up redux-persist types
Summary

This resolves ENG-1593. See this comment.

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
native/
1 line
flow-typed/
npm/

Diff 15646

View Options

native/.flowconfig

// Top-level build file where you can add configuration options common to all sub-projects/modules. // Top-level build file where you can add configuration options common to all sub-projects/modules.
buildscript { buildscript {
ext { ext {
buildToolsVersion = "31.0.0" buildToolsVersion = "31.0.0"
minSdkVersion = 21 minSdkVersion = 21
compileSdkVersion = 31 compileSdkVersion = 31
targetSdkVersion = 31 targetSdkVersion = 31
// We can't use NDK 24 yet because of Folly build issues if (System.properties['os.arch'] == "aarch64") {
// https://linear.app/comm/issue/ENG-2169/update-folly-on-android // For M1 Users we need to use the NDK 24 which added support for aarch64
//if (System.properties['os.arch'] == "aarch64") { ndkVersion = "24.0.8215888"
// // For M1 Users we need to use the NDK 24 which added support for aarch64 } else {
// ndkVersion = "24.0.8215888" // Otherwise we default to the side-by-side NDK version from AGP.
//} else {
// // Otherwise we default to the side-by-side NDK version from AGP.
// ndkVersion = "21.4.7075529"
//}
ndkVersion = "21.4.7075529" ndkVersion = "21.4.7075529"
} }
}
repositories { repositories {
google() google()
mavenCentral() mavenCentral()
} }
dependencies { dependencies {
classpath("com.android.tools.build:gradle:7.2.1") classpath("com.android.tools.build:gradle:7.2.1")
classpath("com.facebook.react:react-native-gradle-plugin") classpath("com.facebook.react:react-native-gradle-plugin")
classpath("de.undercouch:gradle-download-task:5.0.1") classpath("de.undercouch:gradle-download-task:5.0.1")
Show All 35 Lines
View Options

native/flow-typed/npm/redux-persist_vx.x.x.js

// Top-level build file where you can add configuration options common to all sub-projects/modules. // Top-level build file where you can add configuration options common to all sub-projects/modules.
buildscript { buildscript {
ext { ext {
buildToolsVersion = "31.0.0" buildToolsVersion = "31.0.0"
minSdkVersion = 21 minSdkVersion = 21
compileSdkVersion = 31 compileSdkVersion = 31
targetSdkVersion = 31 targetSdkVersion = 31
// We can't use NDK 24 yet because of Folly build issues if (System.properties['os.arch'] == "aarch64") {
// https://linear.app/comm/issue/ENG-2169/update-folly-on-android // For M1 Users we need to use the NDK 24 which added support for aarch64
//if (System.properties['os.arch'] == "aarch64") { ndkVersion = "24.0.8215888"
// // For M1 Users we need to use the NDK 24 which added support for aarch64 } else {
// ndkVersion = "24.0.8215888" // Otherwise we default to the side-by-side NDK version from AGP.
//} else {
// // Otherwise we default to the side-by-side NDK version from AGP.
// ndkVersion = "21.4.7075529"
//}
ndkVersion = "21.4.7075529" ndkVersion = "21.4.7075529"
} }
}
repositories { repositories {
google() google()
mavenCentral() mavenCentral()
} }
dependencies { dependencies {
classpath("com.android.tools.build:gradle:7.2.1") classpath("com.android.tools.build:gradle:7.2.1")
classpath("com.facebook.react:react-native-gradle-plugin") classpath("com.facebook.react:react-native-gradle-plugin")
classpath("de.undercouch:gradle-download-task:5.0.1") classpath("de.undercouch:gradle-download-task:5.0.1")
Show All 35 Lines