Paths

Table of Contentst

Differential D4891

[web] Make `failed` `boolean` in `PendingMultimediaUpload`
ClosedPublic
Actions

Authored by • abosh on Aug 19 2022, 2:03 PM.

Tags

None

Referenced Files

	F3345883: D4891.id15935.diff
	Fri, Nov 22, 7:22 AM

	F3342569: D4891.diff
	Fri, Nov 22, 1:39 AM

	Unknown Object (File)
	Fri, Nov 8, 5:05 AM

	Unknown Object (File)
	Fri, Nov 8, 3:43 AM

	Unknown Object (File)
	Mon, Oct 28, 5:09 AM

	Unknown Object (File)
	Mon, Oct 28, 5:08 AM

	Unknown Object (File)
	Mon, Oct 28, 5:08 AM

	Unknown Object (File)
	Mon, Oct 28, 5:05 AM

Subscribers

Details

Reviewers

atul
tomek
• jacek

Commits

rCOMM27b9b60c69cc: [web] Make `failed` `boolean` in `PendingMultimediaUpload`

Summary

The same as D4890, but for web. Since we were already using failed as a truthy/falsy type (with the exception of when we wanted to store an error message), converting it to a boolean makes more sense.

Doesn't actually depend on D4890, but adding it to the stack since they're closely related.

Test Plan

Searched through the codebase for all usages of PendingMultimediaUpload for this refactor. Sent some messages on web and console.log(...)'d some things, and everything looked as expected.

Diff Detail

Repository

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• abosh created this revision.Aug 19 2022, 2:03 PM

Herald added a subscriber: ashoat. · View Herald TranscriptAug 19 2022, 2:03 PM

• abosh added a parent revision: D4890: [native] Make `failed` `boolean` in `PendingMultimediaUpload`.Aug 19 2022, 2:04 PM

• abosh added inline comments.

web/input/input-state-container.react.js
867	I think using a ternary here is fine since we're not returning JSX, only strings, and it isn't too long or complicated.

Harbormaster completed remote builds in B11485: Diff 15797.Aug 19 2022, 2:13 PM

• abosh requested review of this revision.Aug 19 2022, 2:13 PM

• abosh edited the summary of this revision. (Show Details)Aug 24 2022, 8:28 AM

Remove failureMessage prop (see discussion on D4890).

Harbormaster completed remote builds in B11590: Diff 15935.Aug 24 2022, 8:41 AM

tomek accepted this revision.Aug 25 2022, 2:27 AM

This revision is now accepted and ready to land.Aug 25 2022, 2:27 AM

Closed by commit rCOMM27b9b60c69cc: [web] Make `failed` `boolean` in `PendingMultimediaUpload` (authored by • abosh). · Explain WhyAug 26 2022, 12:29 PM

This revision was automatically updated to reflect the committed changes.

• abosh added a commit: rCOMM27b9b60c69cc: [web] Make `failed` `boolean` in `PendingMultimediaUpload`.

Revision Contents
Changeset List

Path

Size

web/

input/

input-state-container.react.js

9 lines

5 lines

Diff 15797

web/input/input-state-container.react.js

Loading...

web/input/input-state.js

Loading...