Paths

Table of Contentst

Differential D4930

[web] Memoize `loginButtonContent` and `saveButtonContent`
ClosedPublic
Actions

Authored by • abosh on Aug 23 2022, 2:14 PM.

Details

Reviewers

atul

Commits

rCOMM24746e00189d: [web] Memoize `loginButtonContent` and `saveButtonContent`

Summary

Noticed these could be memoized.

Test Plan

Made sure everything looked as expected on the LogInForm modal and ThreadSettingsGeneralTab save button. Loading indicators showed up correctly, disappeared after submit was complete, etc.

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• abosh created this revision.Aug 23 2022, 2:14 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 23 2022, 2:14 PM

• abosh edited the test plan for this revision. (Show Details)Aug 23 2022, 2:15 PM

Harbormaster completed remote builds in B11555: Diff 15890.Aug 23 2022, 2:24 PM

• abosh requested review of this revision.Aug 23 2022, 2:24 PM

atul accepted this revision.Aug 25 2022, 10:02 PM

atul added inline comments.

web/modals/threads/settings/thread-settings-general-tab.react.js
140	Ah I should have caught this when reviewing D4287

This revision is now accepted and ready to land.Aug 25 2022, 10:02 PM

• abosh marked an inline comment as done.Aug 26 2022, 10:26 AM

Closed by commit rCOMM24746e00189d: [web] Memoize `loginButtonContent` and `saveButtonContent` (authored by • abosh). · Explain WhyAug 26 2022, 10:27 AM

This revision was automatically updated to reflect the committed changes.

• abosh added a commit: rCOMM24746e00189d: [web] Memoize `loginButtonContent` and `saveButtonContent`.

Revision Contents
Changeset List

Path

Size

web/

account/

log-in-form.react.js

12 lines

modals/

threads/

settings/

thread-settings-general-tab.react.js

14 lines

Diff 15890

View Options

web/account/log-in-form.react.js