Page MenuHomePhabricator
Differential D4960

[landing] fixed fatal bundling issue using window outside function scope
ClosedPublic
Actions

Authored by • derek on Aug 26 2022, 11:40 AM.
Tags
None
Referenced Files
F3113831: D4960.diff
Thu, Oct 31, 7:31 PM
Unknown Object (File)
Mon, Oct 28, 5:07 AM
Unknown Object (File)
Mon, Oct 28, 5:07 AM
Unknown Object (File)
Mon, Oct 28, 5:05 AM
Unknown Object (File)
Sun, Oct 6, 2:09 PM
Unknown Object (File)
Sep 23 2024, 4:16 PM
Unknown Object (File)
Sep 16 2024, 2:22 PM
Unknown Object (File)
Sep 16 2024, 2:22 PM
View All 78 Files
Subscribers
• abosh
ashoat
atul
• jacek
tomek

Details

Reviewers
ashoat
atul
• abosh
Commits
rCOMM87421718444f: [landing] fixed fatal bundling issue using window outside function scope
Summary

after merging D4510, for some reason, there is an issue bundling with using the global variable window in the global scope as opposed to inside a function scope. it results in this error message:

Could not load landing.build.cjs. Did you forget to run `yarn dev` in the landing folder?
at getWebpackCompiledRootComponentForSSR (file:///Users/derek/clients/comm/keyserver/dist/responders/landing-handler.js:84:11)
Test Plan

run yarn dev and be able to visit /landing instead of being greeted by a fatal error

Diff Detail

Repository
rCOMM Comm
Branch
derek/siwe-webview
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
landing/
5 lines

Diff 16014

View Options

landing/siwe.react.js

Loading...