Page MenuHomePhabricator

[landing] fixed fatal bundling issue using window outside function scope
ClosedPublic

Authored by derek on Aug 26 2022, 11:40 AM.
Tags
None
Referenced Files
F3529425: D4960.id16014.diff
Tue, Dec 24, 6:34 PM
F3529266: D4960.id16015.diff
Tue, Dec 24, 5:28 PM
F3527283: D4960.diff
Tue, Dec 24, 4:32 AM
Unknown Object (File)
Wed, Dec 18, 1:30 PM
Unknown Object (File)
Nov 11 2024, 1:51 AM
Unknown Object (File)
Nov 9 2024, 6:40 AM
Unknown Object (File)
Nov 8 2024, 4:10 PM
Unknown Object (File)
Oct 31 2024, 11:42 PM

Details

Summary

after merging D4510, for some reason, there is an issue bundling with using the global variable window in the global scope as opposed to inside a function scope. it results in this error message:

Could not load landing.build.cjs. Did you forget to run `yarn dev` in the landing folder?
at getWebpackCompiledRootComponentForSSR (file:///Users/derek/clients/comm/keyserver/dist/responders/landing-handler.js:84:11)
Test Plan

run yarn dev and be able to visit /landing instead of being greeted by a fatal error

Diff Detail

Repository
rCOMM Comm
Branch
derek/siwe-webview
Lint
No Lint Coverage
Unit
No Test Coverage