Page MenuHomePhabricator
Differential D4981

[native] Rename `promises` to `cleanupPromises` at end of uploadFile(...)
ClosedPublic
Actions

Authored by atul on Aug 29 2022, 5:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 17, 8:01 AM
Unknown Object (File)
Wed, Dec 4, 2:42 AM
Unknown Object (File)
Thu, Nov 28, 11:05 AM
Unknown Object (File)
Nov 22 2024, 7:06 AM
Unknown Object (File)
Nov 22 2024, 6:43 AM
Unknown Object (File)
Nov 22 2024, 1:44 AM
Unknown Object (File)
Nov 11 2024, 2:51 AM
Unknown Object (File)
Nov 9 2024, 6:51 AM
View All Files
Subscribers
None

Details

Reviewers
• abosh
• jacek
tomek
ashoat
Commits
rCOMM16897bd6ff2d: [native] Rename `promises` to `cleanupPromises` at end of uploadFile(...)
Summary

There are a lot of promises in uploadFile(...)... figured giving this "section" of them a more descriptive name.

Test Plan

NA, simple rename

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Aug 29 2022, 5:36 PM
Harbormaster completed remote builds in B11704: Diff 16093.Aug 29 2022, 5:43 PM
atul requested review of this revision.Aug 29 2022, 5:43 PM
atul edited the summary of this revision. (Show Details)Aug 29 2022, 5:56 PM
atul added a parent revision: D4980: [native] Update local video messages with realized `thumbnailURI` upon successful upload.
atul added a child revision: D4982: [keyserver] Introduce `legacyMultimediaMessageCreationResponder`.Aug 29 2022, 6:17 PM
• abosh accepted this revision.Aug 29 2022, 10:43 PM

Yup, this makes sense!

This revision is now accepted and ready to land.Aug 29 2022, 10:43 PM
atul updated this revision to Diff 16106.Aug 30 2022, 8:52 AM

rebase around blocked diffs

Harbormaster failed remote builds in B11717: Diff 16106!Aug 30 2022, 8:54 AM
Harbormaster completed remote builds in B11717: Diff 16106.Aug 30 2022, 9:02 AM
Closed by commit rCOMM16897bd6ff2d: [native] Rename `promises` to `cleanupPromises` at end of uploadFile(...) (authored by atul). · Explain WhyAug 30 2022, 9:06 AM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM16897bd6ff2d: [native] Rename `promises` to `cleanupPromises` at end of uploadFile(...).
atul added a comment.Aug 30 2022, 10:32 AM

Sorry... realizing now that this wasn't approved by a final reviewer before landing.

Happy to revert but also it's a super benign change

atul edited the summary of this revision. (Show Details)Aug 30 2022, 1:46 PM
atul removed a parent revision: D4980: [native] Update local video messages with realized `thumbnailURI` upon successful upload.
atul removed a child revision: D4982: [keyserver] Introduce `legacyMultimediaMessageCreationResponder`.

Revision Contents
Changeset List

PathSize
native/
input/
10 lines

Diff 16093

View Options

native/input/input-state-container.react.js

Loading...