We don't seem to use remove_all on the messages side, but we do on the threads side. Was this an oversight?
Details
Details
- Reviewers
atul - Commits
- rCOMM03e8e711df58: [lib] Clear MessageStore on freshMessageStore
Haven't tested yet, mostly just asking posing this as a question
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- ashoat/messagereducer
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
It's been a while so I don't remember exactly... but I probably assumed that the SQLite messages table would be empty prior to logInActionTypes.success (which is the only action type in message-reducer.js for which freshMessageStore(...) is called).
Whether or not that assumption was correct, it doesn't hurt to add a remove_all op at the start for good measure.