Page MenuHomePhabricator
Differential D5792

[native] Removing Tunnelbroker-related protobuf compiled files
ClosedPublic
Actions

Authored by • max on Dec 1 2022, 11:51 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Feb 1, 9:33 AM
Unknown Object (File)
Sat, Feb 1, 9:33 AM
Unknown Object (File)
Sat, Feb 1, 9:33 AM
Unknown Object (File)
Sat, Feb 1, 9:33 AM
Unknown Object (File)
Sun, Jan 26, 1:20 AM
Unknown Object (File)
Sat, Jan 25, 1:01 PM
Unknown Object (File)
Sat, Jan 25, 1:01 PM
Unknown Object (File)
Sat, Jan 25, 1:01 PM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
ashoat
atul
Commits
rCOMM8e7d6f906d9e: [native] Removing Tunnelbroker-related protobuf compiled files
Summary

This diff remove Tunnelbroker-related protobuf compiled files for gRPC-C++ which was removed and these files are no longer needed.

Linear task: ENG-2276

Test Plan
  1. The iOS app is successfully built.
  2. In the XCode project files list there are no files left with the names like %grpc% and %tunnelbroker%.

Diff Detail

Repository
rCOMM Comm
Branch
remove-grpc-from-xcode
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• max created this revision.Dec 1 2022, 11:51 AM
• max held this revision as a draft.
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptDec 1 2022, 11:51 AM
• max published this revision for review.Dec 1 2022, 11:55 AM
• max edited the summary of this revision. (Show Details)
• max edited the test plan for this revision. (Show Details)
• max added reviewers: ashoat, atul.
• max edited the test plan for this revision. (Show Details)
ashoat accepted this revision.Dec 1 2022, 11:57 AM

Please wait for iOS build CI to complete before landing!

This revision is now accepted and ready to land.Dec 1 2022, 11:57 AM
Harbormaster completed remote builds in B13920: Diff 19075.Dec 1 2022, 12:04 PM
• max added a comment.Dec 1 2022, 12:12 PM
In D5792#172828, @ashoat wrote:

Please wait for iOS build CI to complete before landing!

Sure! It's passed now, landing it.

Closed by commit rCOMM8e7d6f906d9e: [native] Removing Tunnelbroker-related protobuf compiled files (authored by • max). · Explain WhyDec 1 2022, 12:12 PM
This revision was automatically updated to reflect the committed changes.
• max added a commit: rCOMM8e7d6f906d9e: [native] Removing Tunnelbroker-related protobuf compiled files.

Revision Contents
Changeset List

PathSize
native/
ios/
Comm.xcodeproj/
33 lines

Diff 19075

View Options

native/ios/Comm.xcodeproj/project.pbxproj

Loading...