Page MenuHomePhabricator
Differential D5965

[lib] Fix return value of `getSIWENonce`
ClosedPublic
Actions

Authored by atul on Dec 20 2022, 11:29 PM.
Tags
None
Referenced Files
F3381391: D5965.id19960.diff
Thu, Nov 28, 4:48 AM
Unknown Object (File)
Fri, Nov 8, 9:13 PM
Unknown Object (File)
Fri, Nov 8, 9:13 PM
Unknown Object (File)
Fri, Nov 8, 9:13 PM
Unknown Object (File)
Fri, Nov 8, 9:13 PM
Unknown Object (File)
Fri, Nov 8, 9:13 PM
Unknown Object (File)
Wed, Nov 6, 3:35 PM
Unknown Object (File)
Tue, Nov 5, 2:08 AM
View All Files
Subscribers
None

Details

Reviewers
ashoat
tomek
Commits
rCOMM08a6eeaec8a3: [lib] Fix return value of `getSIWENonce`
Summary

Fix getSIWENonce to return the nonce (string) as expected instead of the object that's returned by callServerEndpoint('siwe_nonce').

Depends on D5964

Test Plan

Was able to log values and set breakpoints to ensure that things were as expected.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Dec 20 2022, 11:29 PM
atul published this revision for review.Dec 20 2022, 11:29 PM
Harbormaster completed remote builds in B14610: Diff 19930.Dec 20 2022, 11:42 PM
atul added a child revision: D5966: [native] Hit `siwe_nonce` endpoint and pass `nonce` to SIWE `WebView`.Dec 20 2022, 11:44 PM
tomek accepted this revision.Dec 21 2022, 8:37 AM
tomek added inline comments.
lib/actions/siwe-actions.js
13 ↗(On Diff #19930)

We can consider making callServerEndpoint generic in terms of T and returning Promise<T>. Some issues will remain, like validation, but at this point we're also not doing that, so it's still an improvement. Obviously it shouldn't be addressed in this diff or a stack - it is just an idea for the future.

This revision is now accepted and ready to land.Dec 21 2022, 8:37 AM
atul added inline comments.Dec 21 2022, 10:03 AM
lib/actions/siwe-actions.js
13 ↗(On Diff #19930)

Makes sense!

https://linear.app/comm/issue/ENG-2517/consider-making-callserverendpoint-generic-in-terms-of-t-and-returning

atul updated this revision to Diff 19960.Dec 21 2022, 10:05 AM

rebase before landing

Harbormaster completed remote builds in B14636: Diff 19960.Dec 21 2022, 10:19 AM
atul updated this revision to Diff 19961.Dec 21 2022, 10:22 AM

land

This revision was landed with ongoing or failed builds.Dec 21 2022, 10:23 AM
Closed by commit rCOMM08a6eeaec8a3: [lib] Fix return value of `getSIWENonce` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM08a6eeaec8a3: [lib] Fix return value of `getSIWENonce`.
Harbormaster completed remote builds in B14637: Diff 19961.Dec 21 2022, 10:34 AM

Revision Contents
Changeset List

PathSize
lib/
actions/
4 lines

Diff 19962

View Options

lib/actions/siwe-actions.js

Loading...