[landing] Pull `siweNonce` from `SIWENonceContext` and include in SIWE message
ClosedPublic
Actions

Authored by atul on Dec 21 2022, 2:06 PM.

Details

Reviewers

ashoat
tomek

Commits

rCOMM9f5a3147c352: [landing] Pull `siweNonce` from `SIWENonceContext` and include in SIWE message

Summary

Consume SIWENonceContext to retrieve siweNonce and pass to createSiweMessage so the nonce can be included in the signed message.

Depends on D5977

Test Plan

Logged nonce values from keyserver to native to landing to the SIWE message and made sure they were as expected. Also checked the siwe_nonces table to make sure nonce matched the most recent: https://blob.sh/139f21.png

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Dec 21 2022, 2:06 PM

Harbormaster completed remote builds in B14645: Diff 19978.Dec 21 2022, 2:20 PM

atul requested review of this revision.Dec 21 2022, 2:20 PM

atul added inline comments.Dec 21 2022, 2:33 PM

landing/siwe.react.js
43 ↗	(On Diff #19978)	Yes the way things are right now it's impossible for this situation to occur, but I wanted to be extra careful so included this precondition.
59 ↗	(On Diff #19978)	Yes the way things are right now it's impossible for this situation to occur, but I wanted to be extra careful so included this precondition.

ashoat accepted this revision.Dec 21 2022, 5:34 PM

ashoat mentioned this in D5977: [keyserver] Capture `siwe-nonce` header and make available to `SIWE` component.

ashoat added inline comments.

landing/siwe.react.js
42 ↗	(On Diff #19978)	Can you annotate the types? It helps for documentation imo

This revision is now accepted and ready to land.Dec 21 2022, 5:34 PM

annotate function argument types

atul added inline comments.Dec 21 2022, 11:59 PM

landing/siwe.react.js
42 ↗	(On Diff #19978)	Typed `address`, `statement` and `nonce` here... unfortunately the `signer` argument for `signInWithEthereum` is a bit more complex: so I created a task: https://linear.app/comm/issue/ENG-2522/flow-type-signer-in-landingsiwe-component and will defer for now.