Page MenuHomePhabricator
Differential D6006

[landing] Fix up CSS for RainbowKit / WalletConnect
ClosedPublic
Actions

Authored by ashoat on Dec 22 2022, 3:46 PM.
Tags
None
Referenced Files
F3521381: D6006.id20057.diff
Mon, Dec 23, 3:25 AM
F3520129: D6006.diff
Sun, Dec 22, 11:29 PM
Unknown Object (File)
Wed, Dec 4, 11:48 AM
Unknown Object (File)
Wed, Dec 4, 11:48 AM
Unknown Object (File)
Wed, Dec 4, 11:48 AM
Unknown Object (File)
Wed, Dec 4, 11:29 AM
Unknown Object (File)
Nov 8 2024, 6:38 PM
Unknown Object (File)
Nov 5 2024, 7:29 AM
View All Files
Subscribers
tomek

Details

Reviewers
atul
Commits
rCOMM0199139921f8: [landing] Fix up CSS for RainbowKit / WalletConnect
Summary

Hacky, but it works.

Test Plan
beforeafter
Screenshot 2022-12-22 at 4.38.22 PM.png (2×1 px, 1 MB)
Screenshot 2022-12-22 at 4.39.38 PM.png (2×1 px, 1 MB)
Screenshot 2022-12-22 at 4.38.27 PM.png (2×1 px, 1 MB)
Screenshot 2022-12-22 at 4.39.44 PM.png (2×1 px, 1 MB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.Dec 22 2022, 3:46 PM
Herald added a subscriber: tomek. · View Herald TranscriptDec 22 2022, 3:46 PM
ashoat edited the test plan for this revision. (Show Details)Dec 22 2022, 3:47 PM

All the initial stuff is to undo things we set in global.css. Long-term solution is ENG-2531, but don't have time for that right now.

div.walletconnect-modal__footer changes don't seem to have to do with global.css or reset.css.

Harbormaster completed remote builds in B14700: Diff 20042.Dec 22 2022, 3:59 PM
ashoat requested review of this revision.Dec 22 2022, 3:59 PM
atul accepted this revision.Dec 22 2022, 10:04 PM
This revision is now accepted and ready to land.Dec 22 2022, 10:04 PM
Closed by commit rCOMM0199139921f8: [landing] Fix up CSS for RainbowKit / WalletConnect (authored by ashoat). · Explain WhyDec 23 2022, 6:14 AM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM0199139921f8: [landing] Fix up CSS for RainbowKit / WalletConnect.

Revision Contents
Changeset List

PathSize
landing/
12 lines

Diff 20057

View Options

landing/siwe.css

Loading...