[native] Set incognito for SIWE WebView
ClosedPublic
Actions

Authored by ashoat on Dec 25 2022, 6:55 PM.

Details

Reviewers

atul

Commits

rCOMMcb33aef98884: [native] Set incognito for SIWE WebView

Summary

You can get stuck halfway through the SIWE flow if RainbowKit in JS thinks you're authenticated, but your Rainbow app doesn't.

By setting incognito={true}, we reset the state of the WebView on every open, so that we can start the flow from scratch.

Depends on D6035

Test Plan

Get stuck halfway through SIWE flow, then apply this diff and see myself automatically unstuck

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Dec 25 2022, 6:55 PM

Herald added a subscriber: tomek. · View Herald TranscriptDec 25 2022, 6:55 PM

ashoat added a child revision: D6037: [native] Allow rainbow scheme in iOS app.Dec 25 2022, 6:56 PM

Harbormaster completed remote builds in B14751: Diff 20116.Dec 25 2022, 7:09 PM

ashoat requested review of this revision.Dec 25 2022, 7:09 PM

atul accepted this revision.Dec 26 2022, 2:01 AM

This revision is now accepted and ready to land.Dec 26 2022, 2:01 AM

Closed by commit rCOMMcb33aef98884: [native] Set incognito for SIWE WebView (authored by ashoat). · Explain WhyDec 26 2022, 4:51 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMcb33aef98884: [native] Set incognito for SIWE WebView.

ashoat removed a parent revision: D6035: [native] Set SIWE WebView background color.Dec 26 2022, 4:52 AM

Revision Contents
Changeset List

Path

Size

native/

account/

siwe-panel.react.js

1 line

Diff 20116

View Options

native/account/siwe-panel.react.js

[native] Set incognito for SIWE WebViewClosedPublicActions