[native] Allow rainbow scheme in iOS app
ClosedPublic
Actions

Authored by ashoat on Dec 25 2022, 6:56 PM.

Details

Reviewers

atul

Commits

rCOMMcf07423d7c4b: [native] Allow rainbow scheme in iOS app

Summary

This lets us open rainbow:// scheme URLs, which open in the Rainbow Ethereum wallet app.

We should do this for other wallet apps too; ENG-2542 tracks this.

Depends on D6036

Test Plan

Confirm Comm app can open Rainbow app during SIWE flow

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Dec 25 2022, 6:56 PM

Herald added a subscriber: tomek. · View Herald TranscriptDec 25 2022, 6:56 PM

Harbormaster completed remote builds in B14752: Diff 20117.Dec 25 2022, 7:10 PM

ashoat requested review of this revision.Dec 25 2022, 7:10 PM

ashoat retitled this revision from [native] Allow rainbow: scheme in app to [native] Allow rainbow scheme in iOS app.Dec 25 2022, 7:31 PM

atul accepted this revision.Dec 26 2022, 2:01 AM

This revision is now accepted and ready to land.Dec 26 2022, 2:01 AM

Closed by commit rCOMMcf07423d7c4b: [native] Allow rainbow scheme in iOS app (authored by ashoat). · Explain WhyDec 26 2022, 4:51 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMcf07423d7c4b: [native] Allow rainbow scheme in iOS app.

Revision Contents
Changeset List

Path

Size

native/

ios/

Comm/

Info.debug.plist

1 line

Info.release.plist

1 line

Diff 20121

View Options

native/ios/Comm/Info.debug.plist