Page MenuHomePhabricator
Differential D6089

[native] Reverting D5999 and D6000
ClosedPublic
Actions

Authored by • max on Dec 29 2022, 2:37 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 19, 4:04 AM
Unknown Object (File)
Thu, Dec 19, 3:53 AM
Unknown Object (File)
Thu, Dec 19, 12:49 AM
Unknown Object (File)
Wed, Dec 18, 6:16 PM
Unknown Object (File)
Wed, Dec 18, 6:16 PM
Unknown Object (File)
Wed, Dec 18, 6:16 PM
Unknown Object (File)
Wed, Dec 18, 10:59 AM
Unknown Object (File)
Sat, Nov 30, 4:03 PM
View All Files
Subscribers
atul

Details

Reviewers
ashoat
tomek
Commits
rCOMMe01e78fb8b04: [native] Reverting D5999 and D6000
Summary

This diff reverts D5999 and D6000 commits that include the Rust function with using of OpenSSL. As we having a problem with the OpenSSL and CI building in GitHub Actions these diffs will be landed after the issue would be resolved.

Test Plan

CI gates are green.

Diff Detail

Repository
rCOMM Comm
Branch
revert-openssl-functions
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• max created this revision.Dec 29 2022, 2:37 AM
• max held this revision as a draft.
Herald added a subscriber: atul. · View Herald TranscriptDec 29 2022, 2:37 AM
• max updated this revision to Diff 20304.Dec 29 2022, 2:40 AM

Fix commits.

• max published this revision for review.Dec 29 2022, 2:43 AM
• max edited the summary of this revision. (Show Details)
• max edited the test plan for this revision. (Show Details)
• max added 2 blocking reviewer(s): tomek, ashoat.
• max added reverted changes: D6000: [native/rust_library] Adding unit test for the `sign_string_with_private_key` function, D5999: [native/rust_library] Adding `sign_string_with_private_key` function to crypto tools.
Harbormaster completed remote builds in B14886: Diff 20303.Dec 29 2022, 2:48 AM
Harbormaster completed remote builds in B14887: Diff 20304.Dec 29 2022, 2:54 AM
• max removed 1 blocking reviewer(s): tomek.Dec 29 2022, 3:31 AM
tomek accepted this revision.Dec 29 2022, 4:30 AM
ashoat accepted this revision.Dec 29 2022, 8:09 AM
This revision is now accepted and ready to land.Dec 29 2022, 8:09 AM
Closed by commit rCOMMe01e78fb8b04: [native] Reverting D5999 and D6000 (authored by • max). · Explain WhyDec 29 2022, 8:12 AM
This revision was automatically updated to reflect the committed changes.
• max added a commit: rCOMMe01e78fb8b04: [native] Reverting D5999 and D6000.

Revision Contents
Changeset List

PathSize
.github/
workflows/
5 lines
5 lines

Diff 20303

View Options

.github/workflows/android_ci.yml

Loading...
View Options

.github/workflows/android_release.yml

Loading...