Page MenuHomePhabricator
Differential D6258

[web] Pull `web/SIWE` out from `LogInForm` component
ClosedPublic
Actions

Authored by atul on Jan 12 2023, 3:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 4, 3:19 PM
Unknown Object (File)
Nov 9 2024, 4:24 PM
Unknown Object (File)
Nov 9 2024, 4:23 PM
Unknown Object (File)
Nov 9 2024, 4:22 PM
Unknown Object (File)
Nov 9 2024, 4:22 PM
Unknown Object (File)
Nov 9 2024, 3:49 PM
Unknown Object (File)
Nov 9 2024, 8:49 AM
Unknown Object (File)
Nov 9 2024, 7:13 AM
View All Files
Subscribers
None

Details

Reviewers
ashoat
tomek
Commits
rCOMM597760eaad7e: [web] Pull `web/SIWE` out from `LogInForm` component
Summary

Pull the SIWE-specific stuff out of LogInForm and into its own component. Not to be confused with the landing/SIWE component...

Test Plan

Things continue to work as expected + tested implicitly by subsequent diffs in the stack.

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Jan 12 2023, 3:25 PM
atul updated this revision to Diff 20909.Jan 12 2023, 3:30 PM

remove isDev checks from within web/SIWE

atul published this revision for review.Jan 12 2023, 3:31 PM
Harbormaster completed remote builds in B15331: Diff 20908.Jan 12 2023, 3:37 PM
Harbormaster completed remote builds in B15332: Diff 20909.Jan 12 2023, 3:44 PM
ashoat accepted this revision.Jan 12 2023, 4:07 PM

Assuming this is a clean refactor. Separately, please address my comment in D6225 – confused why the call to generate the nonce can't just be triggered on the initial button press

This revision is now accepted and ready to land.Jan 12 2023, 4:07 PM
atul updated this revision to Diff 20913.Jan 12 2023, 4:12 PM

rebase before making changes

atul updated this revision to Diff 20914.Jan 12 2023, 4:14 PM

rebase before landing

atul updated this revision to Diff 20915.Jan 12 2023, 4:16 PM

get rid of no longer relevant isDev check...

atul updated this revision to Diff 20916.Jan 12 2023, 4:19 PM

and handle merge conflicts...

Harbormaster failed remote builds in B15337: Diff 20916!Jan 12 2023, 4:26 PM
Harbormaster completed remote builds in B15334: Diff 20913.Jan 12 2023, 4:29 PM
Harbormaster completed remote builds in B15335: Diff 20914.Jan 12 2023, 4:37 PM
Harbormaster completed remote builds in B15336: Diff 20915.Jan 12 2023, 4:47 PM
This revision was landed with ongoing or failed builds.Jan 14 2023, 1:13 PM
Closed by commit rCOMM597760eaad7e: [web] Pull `web/SIWE` out from `LogInForm` component (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM597760eaad7e: [web] Pull `web/SIWE` out from `LogInForm` component.

Revision Contents
Changeset List

PathSize
web/
account/
32 lines
141 lines
36 lines
155 lines

Diff 20909

View Options

web/account/log-in-form.css

Loading...
View Options

web/account/log-in-form.react.js

Loading...
View Options

web/account/siwe.css

Loading...
View Options

web/account/siwe.react.js

Loading...