Differential D6260

alchemy.json file in release GitHub Actions
ClosedPublic
Actions

Authored by ashoat on Jan 13 2023, 7:18 AM.

Details

Reviewers

atul

Commits

rCOMM52d0d63f631f: [native] Create native/facts/alchemy.json file in release GitHub Actions

Summary

Context in ENG-2589. We need the Alchemy key in the mobile app so we can do ENS lookups.

Test Plan

Test plan described here: https://linear.app/comm/issue/ENG-2589#comment-e9f23909

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Jan 13 2023, 7:18 AM

Herald added a subscriber: tomek. · View Herald TranscriptJan 13 2023, 7:18 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 13 2023, 7:20 AM

Harbormaster failed remote builds in B15350: Diff 20930!

Rebase on master to fix CI

Harbormaster completed remote builds in B15351: Diff 20932.Jan 13 2023, 8:37 AM

ashoat requested review of this revision.Jan 13 2023, 8:37 AM

Make the directory if it doesn't exist already

ashoat edited the test plan for this revision. (Show Details)Jan 13 2023, 9:15 AM

Testing complete!! This works

Harbormaster completed remote builds in B15352: Diff 20942.Jan 14 2023, 5:24 PM

👍🏽

This revision is now accepted and ready to land.Jan 16 2023, 5:42 PM

Closed by commit rCOMM52d0d63f631f: [native] Create native/facts/alchemy.json file in release GitHub Actions (authored by ashoat). · Explain WhyJan 16 2023, 7:39 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM52d0d63f631f: [native] Create native/facts/alchemy.json file in release GitHub Actions.

Revision Contents
Changeset List

Path

Size

.github/

workflows/

android_release.yml

6 lines

ios_release.yml

6 lines

Diff 20932

View Options

.github/workflows/android_release.yml