Paths

Table of Contentst

Differential D6421

[native] Show your ENS name in ProfileScreen
ClosedPublic
Actions

Authored by ashoat on Jan 27 2023, 8:16 PM.

Tags

None

Referenced Files

	F348006: Screenshot 2023-01-27 at 3.15.47 PM.png
	Jan 27 2023, 8:17 PM

Subscribers

Details

Reviewers

Commits

rCOMM1518d021a552: [native] Show your ENS name in ProfileScreen

Summary

Depends on D6420

Test Plan

Screenshot 2023-01-27 at 3.15.47 PM.png (1×565 px, 174 KB)

Diff Detail

Repository

Branch

ashoat/ens

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Jan 27 2023, 8:16 PM

Herald added a subscriber: tomek. · View Herald TranscriptJan 27 2023, 8:16 PM

ashoat edited the test plan for this revision. (Show Details)Jan 27 2023, 8:17 PM

Harbormaster completed remote builds in B15749: Diff 21473.Jan 27 2023, 8:30 PM

ashoat requested review of this revision.Jan 27 2023, 8:30 PM

ashoat added a child revision: D6422: [web] Show your ENS name in AccountSettings.Jan 27 2023, 8:30 PM

atul accepted this revision.Jan 27 2023, 9:35 PM

This revision is now accepted and ready to land.Jan 27 2023, 9:35 PM

atul added inline comments.Jan 27 2023, 9:35 PM

native/profile/profile-screen.react.js
72	Is there a scenario where we expect `stringForUser` to be `null` or `undefined`?

ashoat added inline comments.Jan 27 2023, 10:54 PM

native/profile/profile-screen.react.js
72	When the user logs out or deletes their account, `currentUserInfo` is immediately updated but `ProfileScreen` can remain visible as it animates away

Closed by commit rCOMM1518d021a552: [native] Show your ENS name in ProfileScreen. · Explain WhyJan 27 2023, 10:55 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM1518d021a552: [native] Show your ENS name in ProfileScreen.

Revision Contents
Changeset List

Path

Size

native/

profile/

profile-screen.react.js

12 lines

Diff 21473

native/profile/profile-screen.react.js

Loading...