Page MenuHomePhabricator
Differential D6421

[native] Show your ENS name in ProfileScreen
ClosedPublic
Actions

Authored by ashoat on Jan 27 2023, 12:16 PM.
Tags
None
Referenced Files
F2902870: D6421.id21473.diff
Sat, Oct 5, 7:28 PM
Unknown Object (File)
Mon, Sep 30, 7:16 AM
Unknown Object (File)
Thu, Sep 26, 2:49 AM
Unknown Object (File)
Thu, Sep 12, 2:53 AM
Unknown Object (File)
Thu, Sep 12, 2:53 AM
Unknown Object (File)
Thu, Sep 12, 2:52 AM
Unknown Object (File)
Thu, Sep 12, 2:50 AM
Unknown Object (File)
Aug 11 2024, 6:36 AM
View All 41 Files
Subscribers
tomek

Details

Reviewers
atul
Commits
rCOMM1518d021a552: [native] Show your ENS name in ProfileScreen
Summary

Depends on D6420

Test Plan

Screenshot 2023-01-27 at 3.15.47 PM.png (1×565 px, 174 KB)

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/ens
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Jan 27 2023, 12:16 PM
Herald added a subscriber: tomek. · View Herald TranscriptJan 27 2023, 12:16 PM
ashoat edited the test plan for this revision. (Show Details)Jan 27 2023, 12:17 PM
Harbormaster completed remote builds in B15749: Diff 21473.Jan 27 2023, 12:30 PM
ashoat requested review of this revision.Jan 27 2023, 12:30 PM
ashoat added a child revision: D6422: [web] Show your ENS name in AccountSettings.Jan 27 2023, 12:30 PM
atul accepted this revision.Jan 27 2023, 1:35 PM
This revision is now accepted and ready to land.Jan 27 2023, 1:35 PM
atul added inline comments.Jan 27 2023, 1:35 PM
native/profile/profile-screen.react.js
72

Is there a scenario where we expect stringForUser to be null or undefined?

ashoat added inline comments.Jan 27 2023, 2:54 PM
native/profile/profile-screen.react.js
72

When the user logs out or deletes their account, currentUserInfo is immediately updated but ProfileScreen can remain visible as it animates away

Closed by commit rCOMM1518d021a552: [native] Show your ENS name in ProfileScreen (authored by ashoat). · Explain WhyJan 27 2023, 2:55 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM1518d021a552: [native] Show your ENS name in ProfileScreen.

Revision Contents
Changeset List

PathSize
native/
profile/
12 lines

Diff 21473

View Options

native/profile/profile-screen.react.js

Loading...