Paths

Table of Contentst

Differential D6473

[web] Show ENS names for HistoryEntry
ClosedPublic
Actions

Authored by ashoat on Jan 30 2023, 1:30 PM.

Details

Reviewers

atul

Commits

rCOMM7d07bbbff04d: [web] Show ENS names for HistoryEntry

Summary

I went ahead and changed EntryInfo.creator for this diff. It's a client-only type that's only touched in web.

Test Plan

I used this patch to get ENS to work in my dev environment

Screenshot 2023-01-30 at 4.17.26 PM.png (594×652 px, 36 KB)

Diff Detail

Repository

rCOMM Comm

Branch

ashoat/ens

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Jan 30 2023, 1:30 PM

Herald added a subscriber: tomek. · View Herald TranscriptJan 30 2023, 1:30 PM

ashoat edited the test plan for this revision. (Show Details)Jan 30 2023, 1:33 PM

Harbormaster completed remote builds in B15863: Diff 21647.Jan 30 2023, 1:46 PM

ashoat requested review of this revision.Jan 30 2023, 1:46 PM

atul accepted this revision.Jan 30 2023, 1:52 PM

This revision is now accepted and ready to land.Jan 30 2023, 1:52 PM

Closed by commit rCOMM7d07bbbff04d: [web] Show ENS names for HistoryEntry (authored by ashoat). · Explain WhyJan 31 2023, 4:46 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM7d07bbbff04d: [web] Show ENS names for HistoryEntry.

Revision Contents
Changeset List

Path

Size

lib/

shared/

entry-utils.js

2 lines

types/

entry-types.js

4 lines

web/

modals/

history/

history-entry.react.js

26 lines

Diff 21647

View Options

lib/shared/entry-utils.js

View Options

lib/types/entry-types.js

View Options

web/modals/history/history-entry.react.js

[web] Show ENS names for HistoryEntryClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 21647

lib/shared/entry-utils.js

lib/types/entry-types.js

web/modals/history/history-entry.react.js

[web] Show ENS names for HistoryEntry
ClosedPublic
Actions

Revision Contents
Changeset List