MessagePreview on native and web don't need this, but web/modals/threads/subchannels/subchannel.react.js and web/modals/threads/sidebars/sidebar.react.js sort of do since the result of useMessagePreview gets passed to a React.useMemo. Not clear if those particular React.useMemos are very useful, but this is still good practice in case eg. other places call this in the future.
Details
Details
- Reviewers
atul - Commits
- rCOMM462d81234c37: [lib] Add memoization to useMessagePreview
Summary
Test Plan
Flow
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Herald added a subscriber: tomek. · View Herald TranscriptFeb 3 2023, 12:16 PM2023-02-03 12:16:45 (UTC-8)
ashoat added a child revision: D6562: [lib] Return EntityText from getMessageTitle.Feb 3 2023, 12:18 PM2023-02-03 12:18:03 (UTC-8)
Harbormaster completed remote builds in B16072: Diff 21959.Feb 3 2023, 12:36 PM2023-02-03 12:36:09 (UTC-8)
This revision is now accepted and ready to land.Feb 4 2023, 11:16 AM2023-02-04 11:16:20 (UTC-8)
Closed by commit rCOMM462d81234c37: [lib] Add memoization to useMessagePreview (authored by ashoat). · Explain WhyFeb 5 2023, 7:53 AM2023-02-05 07:53:28 (UTC-8)
This revision was automatically updated to reflect the committed changes.