Paths

Table of Contentst

Differential D6590

[lib] Don't pass threadID in twice to getNameForThreadEntity
ClosedPublic
Actions

Authored by ashoat on Feb 4 2023, 6:22 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Dec 8, 7:06 AM

	Unknown Object (File)
	Fri, Nov 22, 12:56 PM

	Unknown Object (File)
	Nov 18 2024, 7:37 PM

	Unknown Object (File)
	Nov 18 2024, 7:37 PM

	Unknown Object (File)
	Nov 18 2024, 7:36 PM

	Unknown Object (File)
	Nov 18 2024, 7:36 PM

	Unknown Object (File)
	Oct 28 2024, 4:16 PM

	Unknown Object (File)
	Oct 26 2024, 9:01 PM

View All 88 Files

Subscribers

Details

Reviewers

Commits

rCOMM44e05982b7fe: [lib] Don't pass threadID in twice to getNameForThreadEntity

Summary

This is already being passed in via params. This diff should be a no-op... just simplifying the code.

Depends on D6589

Test Plan

Flow, play around with app, tested in combination with following diffs

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Feb 4 2023, 6:22 PM

Herald added a subscriber: tomek. · View Herald TranscriptFeb 4 2023, 6:22 PM

ashoat added a child revision: D6591: [lib] Introduce entity-helpers.js to help resolve ThreadInfo into ResolvedThreadInfo.Feb 4 2023, 6:23 PM

Harbormaster completed remote builds in B16111: Diff 22003.Feb 4 2023, 6:37 PM

ashoat requested review of this revision.Feb 4 2023, 6:37 PM

atul accepted this revision.Feb 5 2023, 10:45 AM

This revision is now accepted and ready to land.Feb 5 2023, 10:45 AM

Closed by commit rCOMM44e05982b7fe: [lib] Don't pass threadID in twice to getNameForThreadEntity (authored by ashoat). · Explain WhyFeb 5 2023, 12:34 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM44e05982b7fe: [lib] Don't pass threadID in twice to getNameForThreadEntity.

Revision Contents
Changeset List

Path

Size

lib/

utils/

7 lines

Diff 22075

lib/utils/entity-text.js

Loading...