Differential D6596

[native] Fetch ENS names in ThreadSettings
ClosedPublic
Actions

Authored by ashoat on Feb 4 2023, 6:27 PM.

Tags

None

Referenced Files

	F3502445: D6596.id22009.diff
	Fri, Dec 20, 4:08 AM

	Unknown Object (File)
	Tue, Dec 17, 11:12 PM

	Unknown Object (File)
	Mon, Dec 16, 8:18 PM

	Unknown Object (File)
	Sat, Nov 30, 7:02 AM

	Unknown Object (File)
	Nov 14 2024, 8:22 PM

	Unknown Object (File)
	Nov 14 2024, 8:22 PM

	Unknown Object (File)
	Nov 14 2024, 8:22 PM

	Unknown Object (File)
	Nov 14 2024, 8:22 PM

View All 92 Files

Subscribers

Details

Reviewers

Commits

rCOMMc7168d411bbf: [native] Fetch ENS names in ThreadSettings

Summary

Depends on D6595

Test Plan

Screenshot 2023-02-05 at 1.47.49 AM.png (2×1 px, 905 KB)

Screenshot 2023-02-05 at 1.48.02 AM.png (2×1 px, 910 KB)

Screenshot 2023-02-05 at 1.48.55 AM.png (2×1 px, 831 KB)

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Feb 4 2023, 6:27 PM

Herald added a subscriber: tomek. · View Herald TranscriptFeb 4 2023, 6:27 PM

ashoat added a child revision: D6597: [native] Fetch ENS names in MessageListHeaderTitle.Feb 4 2023, 6:27 PM

Harbormaster completed remote builds in B16117: Diff 22009.Feb 4 2023, 6:52 PM

ashoat requested review of this revision.Feb 4 2023, 6:52 PM

ashoat edited the test plan for this revision. (Show Details)Feb 4 2023, 10:49 PM

atul accepted this revision.Feb 5 2023, 11:26 AM

This revision is now accepted and ready to land.Feb 5 2023, 11:26 AM

Closed by commit rCOMMc7168d411bbf: [native] Fetch ENS names in ThreadSettings (authored by ashoat). · Explain WhyFeb 5 2023, 12:34 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMc7168d411bbf: [native] Fetch ENS names in ThreadSettings.

Revision Contents
Changeset List

Path

Size

lib/

utils/

entity-helpers.js

51 lines

native/

chat/

settings/

delete-thread.react.js

15 lines

thread-settings-delete-thread.react.js

4 lines

thread-settings-name.react.js

4 lines

thread-settings.react.js

65 lines

Diff 22081

lib/utils/entity-helpers.js

Loading...

native/chat/settings/delete-thread.react.js

Loading...

native/chat/settings/thread-settings-delete-thread.react.js

Loading...

native/chat/settings/thread-settings-name.react.js

Loading...

native/chat/settings/thread-settings.react.js

Loading...