Paths

Table of Contentst

[keyserver] Modify `logInRequestInputValidator` to handle `primaryIdentityPublicKey`
ClosedPublic
Actions

Authored by atul on Feb 7 2023, 2:23 PM.

Details

Reviewers

ashoat
tomek

Commits

rCOMM285d75ac077f: [keyserver] Modify `logInRequestInputValidator` to handle…

Summary

Context: https://linear.app/comm/issue/ENG-1967/update-clients-to-generate-a-publicprivate-keypair-when-authing

Test Plan

Current "traditional" login flow continues to work as expected on native and web.

Request which includes primaryIdentityPublicKey will be tested implicitly by subsequent diffs.

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Feb 7 2023, 2:23 PM

atul published this revision for review.Feb 7 2023, 2:28 PM

Harbormaster completed remote builds in B16262: Diff 22239.Feb 7 2023, 2:39 PM

ashoat accepted this revision.Feb 8 2023, 6:17 AM

This revision is now accepted and ready to land.Feb 8 2023, 6:17 AM

rebase + land

This revision was landed with ongoing or failed builds.Feb 8 2023, 7:52 AM

Closed by commit rCOMM285d75ac077f: [keyserver] Modify `logInRequestInputValidator` to handle… (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM285d75ac077f: [keyserver] Modify `logInRequestInputValidator` to handle….

Harbormaster completed remote builds in B16281: Diff 22277.Feb 8 2023, 8:04 AM

Revision Contents
Changeset List

Path

Size

keyserver/

src/

responders/

user-responders.js

3 lines

lib/

utils/

siwe-utils.js

1 line

Diff 22239

View Options

keyserver/src/responders/user-responders.js