Details

Reviewers

ashoat
tomek

Commits

rCOMM4e20c9230b7c: [native] Include `primaryIdentityPublicKey` in `log_in` request

Summary

Include primaryIdentityPublicKey in log_in request from native.

Test Plan

Set breakpoint in logInResponder:

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Feb 9 2023, 7:53 PM

atul published this revision for review.Feb 9 2023, 7:53 PM

atul edited the test plan for this revision. (Show Details)

atul added inline comments.

lib/types/account-types.js
111	Will make this field required once I update `web`

Harbormaster completed remote builds in B16309: Diff 22309.Feb 9 2023, 8:05 PM

rebase

Harbormaster completed remote builds in B16448: Diff 22485.Feb 13 2023, 6:36 PM

ashoat accepted this revision.Feb 13 2023, 6:59 PM

ashoat added a child revision: D6674: [keyserver] Modify `registerRequestInputValidator` to handle `primaryIdentityPublicKey`.

ashoat added inline comments.

native/account/log-in-panel.react.js
243 ↗	(On Diff #22485)	I would destructure and assign to a local var so you don't need to repeat `this.props.` three times

This revision is now accepted and ready to land.Feb 13 2023, 7:01 PM

rebase before addressing feedback

destructure

This revision was landed with ongoing or failed builds.Feb 13 2023, 7:08 PM

Closed by commit rCOMM4e20c9230b7c: [native] Include `primaryIdentityPublicKey` in `log_in` request. · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM4e20c9230b7c: [native] Include `primaryIdentityPublicKey` in `log_in` request.

Harbormaster completed remote builds in B16453: Diff 22493.Feb 13 2023, 7:21 PM

Harbormaster completed remote builds in B16454: Diff 22494.

[native] Include `primaryIdentityPublicKey` in `log_in` request
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 22309

lib/types/account-types.js

native/account/log-in-panel.react.js

[native] Include `primaryIdentityPublicKey` in `log_in` requestClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 22309

lib/types/account-types.js

native/account/log-in-panel.react.js

[native] Include `primaryIdentityPublicKey` in `log_in` request
ClosedPublic
Actions

Revision Contents
Changeset List