Page MenuHomePhabricator
Differential D6678

[lib] Update clean-webpack-plugin to 4.0
ClosedPublic
Actions

Authored by ashoat on Feb 9 2023, 2:48 PM.
Tags
None
Referenced Files
F3489151: D6678.id22376.diff
Wed, Dec 18, 11:46 AM
F3487947: D6678.diff
Wed, Dec 18, 8:46 AM
F3484518: D6678.diff
Tue, Dec 17, 2:25 PM
Unknown Object (File)
Sat, Nov 23, 7:04 PM
Unknown Object (File)
Fri, Nov 22, 12:54 PM
Unknown Object (File)
Fri, Nov 22, 12:54 PM
Unknown Object (File)
Nov 16 2024, 9:42 PM
Unknown Object (File)
Nov 16 2024, 9:42 PM
View All Files
Subscribers
tomek

Details

Reviewers
atul
Commits
rCOMM7247f9a11428: [lib] Update clean-webpack-plugin to 4.0
Summary
  1. I moved this to lib... it's used in lib/webpack/shared.cjs, so I think that's where it should be
  2. I updated from 3.0 to 4.0

Depends on D6677

Test Plan
  1. The only breaking changes listed in the release notes are that support for Node 8 and Webpack 4 was dropped
  2. Ran yarn dev and yarn prod in both web and landing. Ran the web app and landing page and played around

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Feb 9 2023, 2:48 PM
Herald added a subscriber: tomek. · View Herald TranscriptFeb 9 2023, 2:48 PM
ashoat added a child revision: D6679: [lib] Update mini-css-extract-plugin to 1.6.2.Feb 9 2023, 2:48 PM
Harbormaster completed remote builds in B16317: Diff 22319.Feb 9 2023, 3:03 PM
ashoat requested review of this revision.Feb 9 2023, 3:03 PM
atul accepted this revision.Feb 12 2023, 3:38 PM

Hm, would expect some changes to yarn.lock if we're going from ^3.0.0 to 4.0.0?

This revision is now accepted and ready to land.Feb 12 2023, 3:38 PM
atul requested changes to this revision.Feb 12 2023, 3:43 PM

Looks like there were changes that weren't included

822710.png (370×2 px, 152 KB)

This revision now requires changes to proceed.Feb 12 2023, 3:43 PM
ashoat updated this revision to Diff 22349.Feb 12 2023, 4:39 PM

yarn.lock changes

Harbormaster completed remote builds in B16347: Diff 22349.Feb 12 2023, 5:39 PM
atul accepted this revision.Feb 12 2023, 6:51 PM
This revision is now accepted and ready to land.Feb 12 2023, 6:51 PM
Closed by commit rCOMM7247f9a11428: [lib] Update clean-webpack-plugin to 4.0 (authored by ashoat). · Explain WhyFeb 12 2023, 7:55 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM7247f9a11428: [lib] Update clean-webpack-plugin to 4.0.

Revision Contents
Changeset List

PathSize
landing/
1 line
lib/
1 line
web/
1 line

Diff 22319

View Options

landing/package.json

Loading...
View Options

lib/package.json

Loading...
View Options

web/package.json

Loading...