Page MenuHomePhabricator

[lib][landing][web] Move Webpack to lib
ClosedPublic

Authored by ashoat on Feb 9 2023, 2:47 PM.
Tags
None
Referenced Files
F3488897: D6676.id22317.diff
Wed, Dec 18, 11:05 AM
F3488081: D6676.diff
Wed, Dec 18, 9:03 AM
Unknown Object (File)
Fri, Dec 6, 1:19 AM
Unknown Object (File)
Thu, Dec 5, 8:21 PM
Unknown Object (File)
Nov 16 2024, 9:42 PM
Unknown Object (File)
Nov 16 2024, 9:41 PM
Unknown Object (File)
Nov 16 2024, 9:41 PM
Unknown Object (File)
Nov 16 2024, 9:41 PM
Subscribers

Details

Summary

The webpack NPM module is imported from lib only, so it makes sense for it to be there.

I considered leaving it in web and landing as well since I suspected perhaps webpack-dev-server or webpack-cli need it to be a peer dependency. But I didn't see any issues running the standard workflows (see test plan) so I figured it wasn't necessary.

Test Plan

Ran yarn dev and yarn prod in both web and landing. Ran the web app and landing page and played around

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable