Page MenuHomePhabricator
Differential D6673

[native] Include `primaryIdentityPublicKey` in `log_in` request
ClosedPublic
Actions

Authored by atul on Feb 9 2023, 11:53 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 10, 6:41 AM
Unknown Object (File)
Sun, Nov 10, 6:41 AM
Unknown Object (File)
Sun, Nov 10, 6:41 AM
Unknown Object (File)
Sun, Nov 10, 6:41 AM
Unknown Object (File)
Sun, Nov 10, 6:41 AM
Unknown Object (File)
Sun, Nov 10, 6:40 AM
Unknown Object (File)
Tue, Nov 5, 2:09 AM
Unknown Object (File)
Tue, Nov 5, 12:59 AM
View All Files
Subscribers
None

Details

Reviewers
ashoat
tomek
Commits
rCOMM4e20c9230b7c: [native] Include `primaryIdentityPublicKey` in `log_in` request
Summary

Include primaryIdentityPublicKey in log_in request from native.

Test Plan

Set breakpoint in logInResponder:

99f144.png (200×1 px, 69 KB)

Diff Detail

Repository
rCOMM Comm
Branch
arcpatch-D6673 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Feb 9 2023, 11:53 AM
atul published this revision for review.Feb 9 2023, 11:53 AM
atul edited the test plan for this revision. (Show Details)
atul added inline comments.
lib/types/account-types.js
111 ↗(On Diff #22309)

Will make this field required once I update web

Harbormaster completed remote builds in B16309: Diff 22309.Feb 9 2023, 12:05 PM
atul updated this revision to Diff 22485.Feb 13 2023, 9:41 AM

rebase

Harbormaster completed remote builds in B16448: Diff 22485.Feb 13 2023, 10:36 AM
ashoat accepted this revision.Feb 13 2023, 10:59 AM
ashoat added a child revision: D6674: [keyserver] Modify `registerRequestInputValidator` to handle `primaryIdentityPublicKey`.
ashoat added inline comments.
native/account/log-in-panel.react.js
243 ↗(On Diff #22485)

I would destructure and assign to a local var so you don't need to repeat this.props. three times

This revision is now accepted and ready to land.Feb 13 2023, 11:01 AM
atul updated this revision to Diff 22493.Feb 13 2023, 11:05 AM

rebase before addressing feedback

atul updated this revision to Diff 22494.Feb 13 2023, 11:07 AM

destructure

This revision was landed with ongoing or failed builds.Feb 13 2023, 11:08 AM
Closed by commit rCOMM4e20c9230b7c: [native] Include `primaryIdentityPublicKey` in `log_in` request (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM4e20c9230b7c: [native] Include `primaryIdentityPublicKey` in `log_in` request.
Harbormaster completed remote builds in B16453: Diff 22493.Feb 13 2023, 11:21 AM
Harbormaster completed remote builds in B16454: Diff 22494.

Revision Contents
Changeset List

PathSize
lib/
types/
1 line
native/
account/
6 lines

Diff 22493

View Options

lib/types/account-types.js

Loading...
View Options

native/account/log-in-panel.react.js

Loading...