Page MenuHomePhabricator
Differential D6719

[web] Move `setPrimaryIdentityPublicKey` up from `SIWELoginForm` to `LoginForm`
ClosedPublic
Actions

Authored by atul on Feb 13 2023, 10:45 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 10, 6:41 AM
Unknown Object (File)
Sun, Nov 10, 6:41 AM
Unknown Object (File)
Sun, Nov 10, 6:41 AM
Unknown Object (File)
Sun, Nov 10, 6:40 AM
Unknown Object (File)
Tue, Nov 5, 2:09 AM
Unknown Object (File)
Mon, Nov 4, 7:17 AM
Unknown Object (File)
Tue, Oct 29, 8:39 AM
Unknown Object (File)
Oct 2 2024, 8:13 PM
View All Files
Subscribers
None

Details

Reviewers
ashoat
tomek
Commits
rCOMM96ad9886d4a5: [web] Move `setPrimaryIdentityPublicKey` up from `SIWELoginForm` to `LoginForm`
Summary

We're going to want the primaryIdentityPublicKey in both SIWELoginForm and TraditionalLoginForm, so we lift the useEffect and setting of primaryIdentityPublicKey "up" so it can be accessed by both child components.

Depends on D6675

Test Plan

primaryIdentityPublicKey continues to be included in SIWE message signing request.

Diff Detail

Repository
rCOMM Comm
Branch
arcpatch-D6719 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Feb 13 2023, 10:45 AM
atul published this revision for review.Feb 13 2023, 10:58 AM
ashoat added a comment.Feb 13 2023, 10:59 AM

Can you please use the Phabricator stack feature going forward? It's hard to tell how your diffs related to each other

ashoat added a parent revision: D6675: [native] Include `primaryIdentityPublicKey` in `register` request.Feb 13 2023, 11:00 AM
Harbormaster completed remote builds in B16451: Diff 22488.Feb 13 2023, 11:00 AM
atul edited the summary of this revision. (Show Details)Feb 13 2023, 11:01 AM
atul edited the summary of this revision. (Show Details)
ashoat accepted this revision.Feb 13 2023, 11:05 AM
This revision is now accepted and ready to land.Feb 13 2023, 11:05 AM
atul updated this revision to Diff 22499.Feb 13 2023, 11:26 AM

rebase

Harbormaster completed remote builds in B16457: Diff 22499.Feb 13 2023, 11:39 AM
Closed by commit rCOMM96ad9886d4a5: [web] Move `setPrimaryIdentityPublicKey` up from `SIWELoginForm` to `LoginForm` (authored by atul). · Explain WhyFeb 13 2023, 11:56 AM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM96ad9886d4a5: [web] Move `setPrimaryIdentityPublicKey` up from `SIWELoginForm` to `LoginForm`.

Revision Contents
Changeset List

PathSize
web/
account/
17 lines
16 lines

Diff 22499

View Options

web/account/log-in-form.react.js

Loading...
View Options

web/account/siwe-login-form.react.js

Loading...