Page MenuHomePhabricator
Differential D6735

[keyserver] Populate `public_key` column of `cookies` table on login
ClosedPublic
Actions

Authored by atul on Feb 14 2023, 10:57 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 28, 9:49 PM
Unknown Object (File)
Oct 13 2024, 10:50 PM
Unknown Object (File)
Oct 13 2024, 10:39 PM
Unknown Object (File)
Oct 10 2024, 12:21 PM
Unknown Object (File)
Oct 10 2024, 11:19 AM
Unknown Object (File)
Oct 10 2024, 10:57 AM
Unknown Object (File)
Oct 10 2024, 6:14 AM
Unknown Object (File)
Oct 10 2024, 5:37 AM
View All Files
Subscribers
None

Details

Reviewers
ashoat
tomek
Commits
rCOMMb475f3094780: [keyserver] Populate `public_key` column of `cookies` table on login
Summary

Populate the public_key column of the cookies table with primaryIdentityPublicKey included in logIn request on successful log in.

Test Plan

public_key column populated as expected following successful INTERACTIVE login on both native and web:

c56ed7.png (152×2 px, 59 KB)

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Feb 14 2023, 10:57 AM
atul published this revision for review.Feb 14 2023, 10:58 AM
atul edited the test plan for this revision. (Show Details)
Harbormaster completed remote builds in B16521: Diff 22601.Feb 14 2023, 11:13 AM
atul added a child revision: D6736: [keyserver] Populate `public_key` column of `cookies` table on register.Feb 14 2023, 11:34 AM
ashoat accepted this revision.Feb 15 2023, 7:24 AM
ashoat added inline comments.
keyserver/src/responders/user-responders.js
361

Getting to the point where this would be better as an object rather than a list of props imo

This revision is now accepted and ready to land.Feb 15 2023, 7:24 AM
atul mentioned this in D6742: [keyserver] Introduce `ProcessSuccessfulLoginParams` type.Feb 15 2023, 12:31 PM
atul added inline comments.Feb 15 2023, 12:33 PM
keyserver/src/responders/user-responders.js
361

Getting to the point where this would be better as an object rather than a list of props imo

D6742

atul updated this revision to Diff 22630.Feb 15 2023, 12:34 PM

rebase+land

This revision was landed with ongoing or failed builds.Feb 15 2023, 12:38 PM
Closed by commit rCOMMb475f3094780: [keyserver] Populate `public_key` column of `cookies` table on login (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMb475f3094780: [keyserver] Populate `public_key` column of `cookies` table on login.
Harbormaster completed remote builds in B16542: Diff 22630.Feb 15 2023, 12:50 PM
atul mentioned this in rCOMMa05e32c59040: [keyserver] Introduce `ProcessSuccessfulLoginParams` type.Feb 16 2023, 9:48 PM

Revision Contents
Changeset List

PathSize
keyserver/
src/
responders/
9 lines

Diff 22601

View Options

keyserver/src/responders/user-responders.js

Loading...