Page MenuHomePhabricator
Differential D6750

[native] Call `getUserPublicKey` in `nativeLogInExtraInfoSelector`
ClosedPublic
Actions

Authored by atul on Feb 16 2023, 10:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 18, 11:02 AM
Unknown Object (File)
Fri, Oct 18, 11:02 AM
Unknown Object (File)
Fri, Oct 18, 11:02 AM
Unknown Object (File)
Fri, Oct 18, 11:02 AM
Unknown Object (File)
Fri, Oct 18, 11:02 AM
Unknown Object (File)
Fri, Oct 18, 10:54 AM
Unknown Object (File)
Sep 25 2024, 4:06 PM
Unknown Object (File)
Sep 22 2024, 1:16 AM
View All Files
Subscribers
None

Details

Reviewers
ashoat
tomek
Commits
rCOMMe465b2e037c8: [native] Call `getUserPublicKey` in `nativeLogInExtraInfoSelector`
Summary

We make the getUserPublicKey(...) JSI call in nativeLogInExtraInfoSelector so we can include the ed25519 key in all login/registration requests from native.

Test Plan

Public key is correctly included in extraInfo

5c9c48.png (158×1 px, 82 KB)

Diff Detail

Repository
rCOMM Comm
Branch
arcpatch-D6750 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Feb 16 2023, 10:49 PM
atul edited the test plan for this revision. (Show Details)Feb 16 2023, 10:49 PM
Harbormaster completed remote builds in B16563: Diff 22661.Feb 16 2023, 11:04 PM
atul requested review of this revision.Feb 16 2023, 11:04 PM
ashoat accepted this revision.Feb 17 2023, 10:18 AM
ashoat added inline comments.
native/account/panel-components.react.js
23 ↗(On Diff #22661)

Can this just be mixed?

This revision is now accepted and ready to land.Feb 17 2023, 10:18 AM
ashoat added a child revision: D6751: [native] Stop fetching `primaryIdentityPublicKey` in `[Login/Register]Panel`.Feb 17 2023, 10:18 AM
atul updated this revision to Diff 22685.Feb 17 2023, 11:25 AM

rebase + land

atul updated this revision to Diff 22686.Feb 17 2023, 11:26 AM

mixed instead of Promise<void>

native/account/panel-components.react.js
23 ↗(On Diff #22661)

Yeah, updated

This revision was landed with ongoing or failed builds.Feb 17 2023, 11:29 AM
Closed by commit rCOMMe465b2e037c8: [native] Call `getUserPublicKey` in `nativeLogInExtraInfoSelector` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMe465b2e037c8: [native] Call `getUserPublicKey` in `nativeLogInExtraInfoSelector`.
Harbormaster completed remote builds in B16584: Diff 22685.Feb 17 2023, 11:41 AM
Harbormaster completed remote builds in B16585: Diff 22686.

Revision Contents
Changeset List

Diff 22685

View Options

lib/types/account-types.js

Loading...
View Options

native/account/log-in-panel.react.js

Loading...
View Options

native/account/panel-components.react.js

Loading...
View Options

native/account/register-panel.react.js

Loading...
View Options

native/account/resolve-invalidated-cookie.js

Loading...
View Options

native/account/siwe-panel.react.js

Loading...
View Options

native/selectors/account-selectors.js

Loading...