Page MenuHomePhabricator
Differential D6751

[native] Stop fetching `primaryIdentityPublicKey` in `[Login/Register]Panel`
ClosedPublic
Actions

Authored by atul on Feb 17 2023, 12:07 AM.
Tags
None
Referenced Files
F3280656: D6751.id22662.diff
Sat, Nov 16, 9:17 AM
F3278044: D6751.id22732.diff
Sat, Nov 16, 8:09 AM
Unknown Object (File)
Mon, Oct 28, 11:27 AM
Unknown Object (File)
Fri, Oct 18, 11:02 AM
Unknown Object (File)
Fri, Oct 18, 11:02 AM
Unknown Object (File)
Fri, Oct 18, 11:02 AM
Unknown Object (File)
Fri, Oct 18, 11:02 AM
Unknown Object (File)
Fri, Oct 18, 11:02 AM
View All Files
Subscribers
None

Details

Reviewers
ashoat
tomek
Commits
rCOMM2d3abdbed139: [native] Stop fetching `primaryIdentityPublicKey` in `[Login/Register]Panel`
Summary

This has been moved to nativeLogInExtraInfoSelector, so no longer necessary.

Test Plan

We're still getting the primaryIdentityPublicKey in requests from native.

Registration:

61fe5c.png (444×1 px, 166 KB)

Login:

6131f7.png (214×1 px, 100 KB)

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Feb 17 2023, 12:07 AM
atul published this revision for review.Feb 17 2023, 12:08 AM
atul edited the test plan for this revision. (Show Details)
Harbormaster completed remote builds in B16564: Diff 22662.Feb 17 2023, 12:22 AM
ashoat accepted this revision.Feb 17 2023, 10:18 AM
ashoat added a parent revision: D6750: [native] Call `getUserPublicKey` in `nativeLogInExtraInfoSelector`.

Added the parent diff for you. Going forward, can you please handle this yourself?

This revision is now accepted and ready to land.Feb 17 2023, 10:19 AM
atul updated this revision to Diff 22693.Feb 17 2023, 11:43 AM

rebase + land

atul added a comment.Feb 17 2023, 11:43 AM
In D6751#201258, @ashoat wrote:

Added the parent diff for you. Going forward, can you please handle this yourself?

Thanks, yeah

Harbormaster completed remote builds in B16587: Diff 22693.Feb 17 2023, 11:58 AM
atul updated this revision to Diff 22728.Feb 20 2023, 9:41 AM

rebase ebfore landing

Harbormaster failed remote builds in B16621: Diff 22728!Feb 20 2023, 9:44 AM
atul updated this revision to Diff 22729.Feb 20 2023, 9:52 AM

hello

Harbormaster failed remote builds in B16622: Diff 22729!Feb 20 2023, 9:54 AM
atul added a comment.Feb 20 2023, 10:09 AM

Tested locally outside of Nix and things built as expected.

This revision was landed with ongoing or failed builds.Feb 20 2023, 10:10 AM
Closed by commit rCOMM2d3abdbed139: [native] Stop fetching `primaryIdentityPublicKey` in `[Login/Register]Panel` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM2d3abdbed139: [native] Stop fetching `primaryIdentityPublicKey` in `[Login/Register]Panel`.

Revision Contents
Changeset List

PathSize
lib/
types/
1 line
native/
account/
26 lines
26 lines

Diff 22693

View Options

lib/types/account-types.js

Loading...
View Options

native/account/log-in-panel.react.js

Loading...
View Options

native/account/register-panel.react.js

Loading...