Page MenuHomePhabricator
Differential D6806

[lib] Add @-mentioned users in initial sidebar message at creation time
ClosedPublic
Actions

Authored by ashoat on Feb 20 2023, 5:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 29, 4:56 PM
Unknown Object (File)
Tue, Oct 29, 4:56 PM
Unknown Object (File)
Tue, Oct 29, 4:56 PM
Unknown Object (File)
Tue, Oct 29, 4:56 PM
Unknown Object (File)
Tue, Oct 29, 4:56 PM
Unknown Object (File)
Tue, Oct 29, 4:52 PM
Unknown Object (File)
Mon, Oct 28, 1:17 PM
Unknown Object (File)
Sun, Oct 20, 10:58 AM
View All Files
Subscribers
tomek

Details

Reviewers
atul
Commits
rCOMMf9d7ccf390ac: [lib] Add @-mentioned users in initial sidebar message at creation time
Summary

This solves ENG-3040.

Depends on D6805

Test Plan

I tested this stack with the following steps on both web and native:

  1. Make sure users get auto-added to a sidebar when @-mentioned
  2. Test mentions typeahead and make sure it includes all members of parent
  3. If a user is @-mentioned in a text message that triggers the creation of a sidebar, then make sure they are included in the sidebar creation message
  4. If a user is @-mentioned in a text message that triggers the creation of a sidebar, then make sure their name is bolded from the very start of when the message is visible on-screen

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Feb 20 2023, 5:50 PM
Herald added a subscriber: tomek. · View Herald TranscriptFeb 20 2023, 5:50 PM
ashoat added a child revision: D6807: [web][native] Rename threadMembers in mentions typeahead code to mentionsCandidates.Feb 20 2023, 5:51 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Feb 20 2023, 6:04 PM
Harbormaster failed remote builds in B16664: Diff 22792!
ashoat updated this revision to Diff 22799.Feb 20 2023, 6:28 PM

Rebase

Harbormaster completed remote builds in B16671: Diff 22799.Feb 20 2023, 6:44 PM
ashoat requested review of this revision.Feb 20 2023, 6:44 PM
atul accepted this revision.Feb 21 2023, 12:24 AM
atul added inline comments.
lib/shared/thread-utils.js
1563–1565 ↗(On Diff #22799)

Could we do

members.push(...mentionedNewMembers);

here?

This revision is now accepted and ready to land.Feb 21 2023, 12:24 AM
ashoat updated this revision to Diff 22831.Feb 21 2023, 6:17 AM

Feedback

Harbormaster completed remote builds in B16697: Diff 22831.Feb 21 2023, 6:33 AM
Closed by commit rCOMMf9d7ccf390ac: [lib] Add @-mentioned users in initial sidebar message at creation time (authored by ashoat). · Explain WhyFeb 21 2023, 6:41 AM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMf9d7ccf390ac: [lib] Add @-mentioned users in initial sidebar message at creation time.

Revision Contents
Changeset List

PathSize
lib/
shared/
30 lines
native/
input/
36 lines
web/
input/
36 lines

Diff 22831

View Options

lib/shared/thread-utils.js

Loading...
View Options

native/input/input-state-container.react.js

Loading...
View Options

web/input/input-state-container.react.js

Loading...