Page MenuHomePhabricator

[web] Patch NavInfo.pendingThread with @-mentions in initial sidebar message
ClosedPublic

Authored by ashoat on Feb 20 2023, 5:53 PM.
Tags
None
Referenced Files
F3249491: D6809.id22795.diff
Fri, Nov 15, 3:27 PM
F3249347: D6809.diff
Fri, Nov 15, 1:47 PM
Unknown Object (File)
Tue, Oct 29, 4:56 PM
Unknown Object (File)
Tue, Oct 29, 4:56 PM
Unknown Object (File)
Tue, Oct 29, 4:56 PM
Unknown Object (File)
Tue, Oct 29, 4:56 PM
Unknown Object (File)
Tue, Oct 29, 4:52 PM
Unknown Object (File)
Sat, Oct 19, 12:42 PM
Subscribers

Details

Summary

If a user starts a sidebar by replying to a message with a new text message, and @-mentions somebody in the text message, then that person gets added to the sidebar when it is created.

However, we have a weird visual behavior today where the person's name doesn't appear bolded while the thread is being created. That's because the pending ThreadInfo in Redux isn't being updated to include the @-mentions.

Depends on D6808

Test Plan

I tested this stack with the following steps on both web and native:

  1. Make sure users get auto-added to a sidebar when @-mentioned
  2. Test mentions typeahead and make sure it includes all members of parent
  3. If a user is @-mentioned in a text message that triggers the creation of a sidebar, then make sure they are included in the sidebar creation message
  4. If a user is @-mentioned in a text message that triggers the creation of a sidebar, then make sure their name is bolded from the very start of when the message is visible on-screen

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable